ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey

Re: ABP 3.1 cosmetic bug?

Postby SGFC » Fri May 18, 2018 7:25 am

I have the same issue and I've even done a clean install of Firefox and ABP. Off topic when I installed ABP it didn't come with Ad Removal Warning filter list anymore. I had to find it and add it.

Screenshot of OP bug;
http://i63.tinypic.com/260qqmd.png

Firefox 60.0.1 64 bit English US
Windows 10 Pro 64 bit (latest updates)

ABP
Greasemonkey
Country Flags and IP Whois
Norton Safe Web
User avatar
SGFC
 
Posts: 33
Joined: Fri Dec 10, 2010 4:51 pm

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby MrGolem » Fri May 18, 2018 6:44 pm

I changed title of my original post. I thought it would make it easier to find/understand. Hope I didn't break anything doing so.

Firefox 60.0.1 is out, updated and bug is still in this version of FF
User avatar
MrGolem
 
Posts: 22
Joined: Wed Nov 25, 2015 2:30 am

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby greiner » Fri May 18, 2018 8:12 pm

The issue has been fixed (see change) and the change will be included in the next extension update. Before that the release has to go through testing together with any other changes that will be part of the next release so it will still take a bit of time before we can roll it out to everyone.
User avatar
greiner
ABP Developer
 
Posts: 669
Joined: Mon Sep 03, 2012 5:29 pm
Location: Cologne, Germany

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby MrGolem » Fri May 18, 2018 9:31 pm

greiner, Great news. Thanks for the info. Thanks for all the help. Have a GREAT Day :-) :-)
User avatar
MrGolem
 
Posts: 22
Joined: Wed Nov 25, 2015 2:30 am

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby Marco » Fri May 18, 2018 11:15 pm

Happy to wait.

Thank you.
Marco
 
Posts: 95
Joined: Sat Dec 12, 2015 9:55 am

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby Starving-Morlock » Tue May 22, 2018 3:33 pm

Just to confirm I have noticed the same problem with FF54.0.1 (32bit) over the last few days and reinstalling Adblock Plus/rebooting FF or changing the filter settings did not fix the issue.

As others have said it is erratic and often the number disappears if you reload the page.

Typically the problem most often occurs for me when using the right mouse click context menu option "View Image" using the Images option in a search engine. But it is very specific only occurring if you left-click on a picture (Google Images and Bing) and then use the "View Image" on the expanded view. If you just use the "View Image " option on the search results page it does not happen.

Glad to read the problem is being addressed, it was beginning to worry me that another FF extension had stopped working as it was meant too.
Starving-Morlock
 
Posts: 3
Joined: Tue May 22, 2018 2:49 pm

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby Starving-Morlock » Tue May 29, 2018 2:28 pm

Still not fixed.

I was on YT a couple of days ago and the issue was very prevalent there too. What I do not understand is that the figure shown is not the total number of ads being blocked on a particular page, it is some sub-set. If you change the tool bar icon settings to display the number of all blocked ads it is usually many more and when you untick the box to swap the setting back the blocked ads numbers disappears completely. Odd behaviour.
Starving-Morlock
 
Posts: 3
Joined: Tue May 22, 2018 2:49 pm

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby greiner » Tue May 29, 2018 3:21 pm

Starving-Morlock wrote:Still not fixed.

We've been gathering translations which usually take a while. The release is expected to go out next week.

Starving-Morlock wrote:What I do not understand is that the figure shown is not the total number of ads being blocked on a particular page, it is some sub-set.

Technically, the number represents how many requests we blocked. Since a single request could create multiple ads but a single ad could require multiple requests, it is admittedly not ideal but this is consistent with how other ad blockers do it, as far as I'm aware of.

The underlying issue is that we cannot determine what a request would've done if the extension hadn't blocked it. For that very same reason we also cannot show you how much bandwith/memory/CPU you saved by blocking those.

Starving-Morlock wrote:If you change the tool bar icon settings to display the number of all blocked ads it is usually many more and when you untick the box to swap the setting back the blocked ads numbers disappears completely. Odd behaviour.

The checkbox only determines whether the "Ads blocked on this page" number should also be shown in the icon. It's not supposed to swap out one number with another one. That's caused by the issue we're talking about in this thread.
User avatar
greiner
ABP Developer
 
Posts: 669
Joined: Mon Sep 03, 2012 5:29 pm
Location: Cologne, Germany

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby Starving-Morlock » Wed May 30, 2018 1:39 pm

Thank you for the explanation.
Starving-Morlock
 
Posts: 3
Joined: Tue May 22, 2018 2:49 pm

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby odiemouse » Mon Jun 25, 2018 9:06 pm

I am having this problem too. Its intermittent, but today its constant on Google Drive, but not other websites.

APB 3.1
Firefox 60.0.2
Windows 10 home, 64bit
Filters:
Adblock Warning Removal List
Easy Privacy
Fanboy's Social Blocking List
Easylist
ALLOW Non-intrusive ads
odiemouse
 
Posts: 3
Joined: Thu Feb 16, 2017 1:09 pm

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby bjergmanden » Thu Jul 12, 2018 1:47 pm

I've been a huge fan of ABP for so many years now, but I'm afraid our relationship is getting close to an end due to what seems to be a neverending set of frustrations caused by its latest versions. I mean, I've been using this once flawless tool to get me rid of all those pesky ads and popups, and it used to do its job amazingly well. But since Firefox changed whatever they did, which rendered ABP not working anymore, even though its compatibility with FF was fixed meanwhile, it kept on behaving oddly ever since. It's almost mid July now and the issue of showing random numbers in the addon's icon is getting increasingly frustrating. I'm seriously considering permanently switching to uBlock Origin if this problem is not fixed soon.

I mean no disrespect for the developer, as I'm a software developer myself and I know how hard a job it is to write code that just works, especially when you're doing it for free, but at the same time I don't think I can continue to be a fan of a tool that's supposed to alleviate an issue, when it's atcually defeating its purpose instead.

/rant :)

My setups are as follows:
ABP 3.1 / FF 61.0.1 (64-bit) / macOS High Sierra 10.13.5 / 15' MacBook Pro mid 2016
ABP 3.1 / FF 60.0.1 (64-bit) / macOS Yosemite 10.10 / 27' iMac late 2013

Filters (the same on both computers): English (EasyList) + Adblock Warning Removal List

Still keeping my hopes up and thanks for all your hard work!
User avatar
bjergmanden
 
Posts: 2
Joined: Thu Jul 12, 2018 1:12 pm
Location: Denmark

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby greiner » Thu Jul 12, 2018 2:04 pm

Unfortunately, there was an exceptionally large delay with this release. Usually the quality assurance part of a release takes about one or two weeks but this time it took about twice as long.

We are confident though that the release is going to happen next Tuesday. I'm sorry for the trouble this is causing and I can say that it's also in our own interest to get releases out as quickly as possible so that we can shift our focus to the following release after that.
User avatar
greiner
ABP Developer
 
Posts: 669
Joined: Mon Sep 03, 2012 5:29 pm
Location: Cologne, Germany

Re: ABP 3.1 cosmetic bug? Icon shows Number even if unchecked

Postby bjergmanden » Fri Jul 13, 2018 10:32 pm

Thank you for clearing things out greiner. Faith in ABP restored :wink:
User avatar
bjergmanden
 
Posts: 2
Joined: Thu Jul 12, 2018 1:12 pm
Location: Denmark

Previous

Return to Adblock Plus for Firefox support

Who is online

Users browsing this forum: Google [Bot] and 14 guests