Possible bug in new v0.5.10 site whitelisting feature

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey

Possible bug in new v0.5.10 site whitelisting feature

Postby justpassinthru » Mon Oct 31, 2005 1:45 pm

I have just upgraded to the new version of Adblock Plus (0.5.10) and there appears to be an odd bug in the new site whitelisting feature. There are a number of charity sites that I visit regularly - The Hunger Site, The Rainforest Site etc. - which all take images from the site "imageserv01.yss4.com" but these images are normally blocked by one of my standard filter rules. As they are the main images for those sites, I want to see them and so I have added that site as a whitelist entry in the new site black/whitelist. However, although it now allows GIF images (*.gif) through, Adblock still blocks the JPEG images! To get it to work correctly, I have had to add a whitelist entry to the normal filter list as follows:

@@imageserv01.yss4.com/images/cache/*.jpg

(Note that the filter rule "@@imageserv01.yss4.com" worked correctly in v0.5.9.2)

Is this a bug or is there a setting that I have missed somewhere?
justpassinthru
 

Re: Possible bug in new v0.5.10 site whitelisting feature

Postby Alan » Mon Oct 31, 2005 8:16 pm

Confirmed.
justpassinthru wrote:I have added that site as a whitelist entry in the new site black/whitelist.

The address of The Hunger Site does not contain imageserv01.yss4.com, so adding it to the site whitelist is inappropriate. You should add @@imageserv01.yss4.com to your regular filter set.
However, although it now allows GIF images (*.gif) through, Adblock still blocks the JPEG images!

You are correct. It does not block the images ending in .jpg. I expected that whitelist filter to unblock the jpg's too. Looks like a bug.

That said, the images that are being blocked, both gif and jpg, are ads, so at least your standard filter rules are working properly.

That said, all of those sites have the look and feel of a scam, like the "Please donate to the victims of Katrina" scam sites. Perhaps they aren't a scam, but merely a gimmick to get people to buy their advertised products. They sure come across like that. Oh, they have popups too, but Fx blocks them.

EDIT: So much for web site impressions. According to Charity Governance, Mercy Corps is a well-known and reputable relief organization, not a scam.
--
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Firefox/1.0.7
Adblock_Plus_0.5.10_enh.xpi
Alan
 

Postby lezuzius » Mon Oct 31, 2005 8:24 pm

ive tried it too: if yss4.com added to block list cant whitelist any part of the site eg @@imageserv*.yss4.com/* or *.yss4.com/*
intersting :/
lezuzius
 

Re: Possible bug in new v0.5.10 site whitelisting feature

Postby Guest » Tue Nov 01, 2005 1:44 pm

Alan wrote:The address of The Hunger Site does not contain imageserv01.yss4.com, so adding it to the site whitelist is inappropriate. You should add @@imageserv01.yss4.com to your regular filter set.

I had such a filter in v0.5.9.2 but when I upgraded to v0.5.10 but it stopped working because it is a site-wide filter, not a specific filter (the images are in various different sub-directories, not in the root). If it is true that Adblock will not whitelist a domain that is different to the site that I am visiting and will no longer whitelist a whole site from the regular filter list (I can see good reasons why that should be the case), it will be a pain because it means that I will have to put in specific filters for every sub-directory that contains images from that site instead of the single filter that I had before. I am very tempted to downgrade to v0.5.9.2 which was easier to use.

That said, all of those sites have the look and feel of a scam, like the "Please donate to the victims of Katrina" scam sites. Perhaps they aren't a scam, but merely a gimmick to get people to buy their advertised products. They sure come across like that. Oh, they have popups too, but Fx blocks them.

EDIT: So much for web site impressions. According to Charity Governance, Mercy Corps is a well-known and reputable relief organization, not a scam.

The Hunger Site has been around for many years (although the original site was under different ownership) and was one of the first, if not the first, sponsored click-to-donate charity site. The Rainforest Site has been around nearly as long. The other related sites are newer but are owned by the same people and have a good reputation AFAIK.

As you say, the main snag is that they use popups which seems unnecessary considering the number of ads on the sites themselves! Fortunately, they are blocked by Fx so they are not a great annoyance to me.
Guest
 

Postby mcm » Tue Nov 01, 2005 4:25 pm

Hmm, normal whitelisting isn't even working at all. Didn't think I had even touched that code. Well, I won't have time this week to look at it but expect a 0.5.10.1 release next week.
User avatar
mcm
 
Posts: 359
Joined: Sat Jun 10, 2006 2:36 am

Postby mcm » Sat Nov 05, 2005 12:01 pm

Very interesting it's a whitelisting bug that affects all versions of Adblock Plus. Basically if you had a filter starting with "http://" it couldn't be unblocked with a white filter. This has been fixed in the development builds linked below. I guess since this bug has been there for a long time and no one noticed it before I'll wait until I have a few more notable changes before releasing a new version.

http://p2.forumforfree.com/development- ... kplus.html
User avatar
mcm
 
Posts: 359
Joined: Sat Jun 10, 2006 2:36 am


Return to Adblock Plus for Firefox support

Who is online

Users browsing this forum: Google [Bot] and 12 guests