Adblock Plus starts late, impacting initial page

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey

Re: Adblock Plus 2.6 starts late, impacting initial page

Postby Dogo » Thu May 22, 2014 3:17 pm

does this thread being unpinned mean it has been acklowledged ?

can we expect any change in the stated dev plan ? (which is basically to only speed up adblock plus startup)
Dogo
 

Re: Adblock Plus 2.6 starts late, impacting initial page

Postby Gingerbread Man » Thu May 22, 2014 7:20 pm

Dogo wrote:does this thread being unpinned mean it has been acklowledged ?

Like I said, I made the thread a temporary sticky. It was unsticked automatically.
Dogo wrote:can we expect any change in the stated dev plan ? (which is basically to only speed up adblock plus startup)

No.
User avatar
Gingerbread Man
 
Posts: 1339
Joined: Fri Aug 12, 2011 5:28 am

Re: Adblock Plus 2.6 starts late, impacting initial page

Postby mapx » Thu May 22, 2014 11:38 pm

Dogo wrote:does this thread being unpinned mean it has been acklowledged ?

can we expect any change in the stated dev plan ? (which is basically to only speed up adblock plus startup)


see
https://issues.adblockplus.org/ticket/529#comment:1

"we are planning to add a setting to ABP to chose whether to delay the startup of Firefox in favour of ABP already running or to start Firefox as quickly as possible with maybe not yet loaded ABP until we managed to improve the speed by a high enough degree."
User avatar
mapx
 
Posts: 21946
Joined: Thu Jan 06, 2011 3:01 pm

Re: Adblock Plus 2.6 starts late, impacting initial page

Postby Supertramp » Fri May 23, 2014 7:43 am

Thanks for the news mapx, that's great ! I'm still concerned about the "until we managed to improve the speed by a high enough degree" bit, because it hints that the option is only temporary and sadly I suspect speed will never be fast enough to prevent network requests to be sent. But we'll see when that time comes I guess, for now it's pretty good news, I was actually starting to dig for good alternatives to ABP :shock: (and I'm a satisfied user since Firefox 2.0...)


The only thing surprising is that none of the developers made us aware of this anywhere. It's always good to show that you listen to your community :)
Supertramp
 

Re: Adblock Plus 2.6 starts late, impacting initial page

Postby mapx » Fri May 23, 2014 12:47 pm

and the official ticket:

https://issues.adblockplus.org/ticket/549

allow users to enforce ABP being loaded completely at Firefox startup, even if delaying it

As the start of ABP at Firefox startup is not fast enough to not significantly delay the whole Firefox opening, we decided to let Firefox start even if ABP is not fully loaded yet. Apparently, this leads to pages with ads and tracking in some cases like #418. Until we were able to speed things up sufficiently, we now want to allow the users to choose whether ABP should definitively start with Firefox, even if this delays the whole startup.

What to change

Allow users to enforce ABP being loaded completely at Firefox startup, even if delaying it
User avatar
mapx
 
Posts: 21946
Joined: Thu Jan 06, 2011 3:01 pm

Re: Adblock Plus 2.6 starts late, impacting initial page

Postby hajj_3 » Fri May 23, 2014 5:57 pm

mapx wrote:"we are planning to add a setting to ABP to chose whether to delay the startup of Firefox in favour of ABP already running or to start Firefox as quickly as possible with maybe not yet loaded ABP until we managed to improve the speed by a high enough degree."


Please don't make this upcoming change temporarily, you aren't going to be able to speed it up enough, just let us have the option to change the setting indefinitely instead. The developers just a few weeks ago said that the current slow speed was fast enough for most and weren't going to change it, i can see you doing that again with a minor speed improvement. As long as it is disabled by default it harms no-one including that setting to load adblock first. Choice is good, dictatorships are bad.
hajj_3
 
Posts: 3
Joined: Tue May 06, 2014 4:32 pm

Re: [549] Adblock Plus 2.6 starts late, impacting initial page

Postby Supertramp » Fri May 23, 2014 8:09 pm

extensions.adblockplus.please_kill_startup_performance


Hahaha, love the name, sounds like this feature is implemented kinda against the developers best wishes xD
Thanks for accepting compromise ;)

Anyway, I would guess that this feature can stay a long time only if its existence doesn't impair future development plans, i.e. if they don't have to maintain two different ABP's in one codebase just so the feature can exist. We'll see how it goes!
Supertramp
 

Re: [549] Adblock Plus 2.6 starts late, impacting initial page

Postby mapx » Fri May 23, 2014 8:32 pm

Supertramp wrote:I would guess that this feature can stay a long time only if its existence doesn't impair future development plans, i.e. if they don't have to maintain two different ABP's in one codebase just so the feature can exist.


the patch was already developed (is under review, probably will land soon in the next dev build), the impact on the code is minor, so ...I guess won't be temporarily
see here:
http://codereview.adblockplus.org/6744383034490880/
User avatar
mapx
 
Posts: 21946
Joined: Thu Jan 06, 2011 3:01 pm

Re: [549] Adblock Plus 2.6 starts late, impacting initial page

Postby Supertramp » Fri May 23, 2014 9:28 pm

And according to that code we should still benefit from future speed improvements and everything. Sounds like the best of both worlds :)

Just need to wait for release build and then for the mozilla.org to update.
Supertramp
 

Re: [549] Adblock Plus 2.6 starts late, impacting initial page

Postby mapx » Fri May 23, 2014 9:31 pm

You can install the dev build when the patch will land in the dev repository
https://adblockplus.org/devbuilds/adblo ... latest.xpi

https://downloads.adblockplus.org/devbu ... elog.xhtml
User avatar
mapx
 
Posts: 21946
Joined: Thu Jan 06, 2011 3:01 pm

Re: [549] Adblock Plus 2.6 starts late, impacting initial page

Postby disturbed » Sat May 24, 2014 10:54 pm

Hurray it's getting fixed! This is HUGE! I'm looking forward to the new build! Yes indeed, PLEASE DO kill my startup performance time so that ABP can load completely! I'm happy now. Let's have a party! Thanks!
disturbed
 
Posts: 2
Joined: Sun May 04, 2014 6:31 pm

Re: [549] Adblock Plus 2.6 starts late, impacting initial page

Postby tsunami2311 » Sun May 25, 2014 3:35 am

Hot damn i cant wait, I rather have FF start slower and have ABP ready to go, then have FF start faster just to have FF freeze whiling loading ABP, seeing the wait time it the same reguardless before FF is useable
tsunami2311
 

Re: [549] Adblock Plus 2.6 starts late, impacting initial page

Postby Oded » Sun May 25, 2014 7:17 am

Thanks for listening (I'm the one who opened this thread...).

Once released, I can reinstall the latest ABP. For now, I've upgraded to ABP 2.5.1 (yes, I upgraded :)) which doesn't have this limitation.

Thanks
Oded
 

Re: [549] Adblock Plus 2.6 starts late, impacting initial page

Postby Taipan » Sun May 25, 2014 2:17 pm

mapx wrote:the patch was already developed (is under review, probably will land soon in the next dev build), the impact on the code is minor, so ...I guess won't be temporarily
see here:
http://codereview.adblockplus.org/6744383034490880/

Lets see what Patch Set 2 looks like ;)
Taipan
 

Re: [549] Adblock Plus 2.6 starts late, impacting initial page

Postby mapx » Mon May 26, 2014 2:10 pm

dev build released
#3822: 2014-05-23 14:25 +0200 Wladimir Palant
Issue 549 - Allow users to enforce ABP being loaded completely at Firefox startup, even if delaying it


go to about:config
find
adblockplus.please_kill_startup_performance
set it to true
User avatar
mapx
 
Posts: 21946
Joined: Thu Jan 06, 2011 3:01 pm

PreviousNext

Return to Adblock Plus for Firefox support

Who is online

Users browsing this forum: No registered users and 11 guests

cron