Page 1 of 1

Filter preferences slow to open

PostPosted: Sat Mar 28, 2015 12:21 pm
by hammel
Can anybody confirm that in recent versions of ABP and/or Firefox the "Filter Preferences"-dialog is opening very slowly?

In an older Firefox-version (24), ABP 2.6.6. with three EasyList-lists and three FanBoy-lists is opening in around 1 second, regardless of how the lists are sorted or which list is selected.

In a recent Nightly with a recent ABP-dev version and the same filterlists, the dialog takes four to eight seconds to open, e10s enabled or not.
Opening the EasyList-filterlist with the lists sorted on "Last hit" takes over 10 seconds. :shock:

Re: Filter preferences slow to open

PostPosted: Sun Mar 29, 2015 7:43 am
by Gingerbread Man
Right-click one of the column headers (e.g. Hits) and choose Sort By, then Unsorted.

You can watch the following bug report for any progress on this. Please don't add comments there unless they're to help diagnose or fix the problem.
https://issues.adblockplus.org/ticket/1620 (RSS feed)

Re: Filter preferences slow to open

PostPosted: Fri Apr 03, 2015 3:54 pm
by hammel
Found the culprit: It's any of the e10s-shims enabled in Nightly 2014-11-03, see https://bugzilla.mozilla.org/show_bug.cgi?id=1063156.

Last good revision: 0e631971b841 (2014-11-02)
First bad revision: 0b81c10a9074 (2014-11-03)
Pushlog: https://hg.mozilla.org/mozilla-central/ ... 81c10a9074

Opening the filter preferences, with sorting set to "Last hit":
Before that build takes about 1 second,
With that build and all newer builds it takes 3 seconds.

Opening the filter-options of EasyList ("Actions"), with sorting set to "Last hit":
Before that build it takes about 3 to 4 seconds.
With that build and all newer builds it takes more than 10 seconds.

You can disable the shims in recent Nightlies with extensions.interposition.enabled;false (see https://bugzilla.mozilla.org/show_bug.cgi?id=1102634).
With that config set, the times drop back to the level of before 2014-11-03.

EDIT:
The regression-range above applies to non-e10s. NOTE: Even with e10s disabled, the user is affected by the e10s-shims! :!:

With e10s enabled, the range is:
Last good revision: 095d2a9c2be5 (2014-07-15)
First bad revision: 869971ad9fd6 (2014-07-16)
Pushlog: https://hg.mozilla.org/mozilla-central/ ... 9971ad9fd6

Probably https://bugzilla.mozilla.org/show_bug.cgi?id=1031609 "Initial compatibility shims for e10s"

Re: Filter preferences slow to open

PostPosted: Tue May 19, 2015 1:14 am
by cmmc
Confirmed, noticed the difference right away - is this safe to disable with e10s disabled (ie: no compatibility issues)?

Re: Filter preferences slow to open

PostPosted: Wed Jun 17, 2015 3:43 pm
by hammel
The shims were optimized recently (http://bugzil.la/1164014 ; Nightly 2015-06-10), so this particular slowdown regarding e10s isn't happening anymore.