Bug in Element Hiding Helper?

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey

Bug in Element Hiding Helper?

Postby cmmc » Fri Jun 17, 2016 10:18 pm

When you use EHH and edit the filter to change the filter to a parent or other element, EHH appends some elements (as I mentioned here: https://adblockplus.org/forum/viewtopic.php?f=1&t=45102#p151412) - this seemed a benign though odd behaviour.

But under certain conditions, when you try the above, the filter is changed in such a way that it becomes too broad and filters out more than what you intend it to.
See here: http://www.zerohedge.com/news/2016-06-17/sanders-supporters-vindicated-proof-dnc-used-media-rig-election-hillary

Select this element:
Code: Select all
zerohedge.com###ad-sidebarleft-top

Now change the filter to this one:
Code: Select all
zerohedge.com###ad-header

You'll end up with this filter:
Code: Select all
zerohedge.com###ad-header + * + * + * > *

The whole page gets filtered out except for some headers.
Fixing the filter solves the problem, which means the culprit is not the filtered element itself.

For the record, these are the filters I use in that site:
Code: Select all
zerohedge.com##.ad-container
zerohedge.com##.ad-container.ad-box
zerohedge.com##.ad-container.ad-banner-vertical.ad-show-text
zerohedge.com###ad-header
zerohedge.com###ad-mobile-leaderboard
Last edited by cmmc on Fri Jun 17, 2016 10:33 pm, edited 1 time in total.
cmmc
 
Posts: 158
Joined: Fri Apr 22, 2011 8:15 pm

Re: Bug in Element Hiding Helper?

Postby mapx » Fri Jun 17, 2016 10:32 pm

I noted it too, I don't know if it's a bug or intended behaviour.
You should report it on the bug tracker:
https://issues.adblockplus.org
User avatar
mapx
 
Posts: 21947
Joined: Thu Jan 06, 2011 3:01 pm

Re: Bug in Element Hiding Helper?

Postby cmmc » Fri Jun 17, 2016 11:58 pm

cmmc
 
Posts: 158
Joined: Fri Apr 22, 2011 8:15 pm


Return to Adblock Plus for Firefox support

Who is online

Users browsing this forum: No registered users and 10 guests