Page 1 of 1

Acceptable ads always enabled after update

PostPosted: Wed Aug 14, 2013 1:56 pm
by Banzi
Hi,

For about the last 4-5 auto updates to the dev builds in Chrome the acceptable ads box is always ticked by default even if unticked before the update.

For example your browsing with chrome with acceptable ads disabled, adblock+ dev build auto updates & shows the adblock page with the switches, when you then go into adblock+ options the acceptable ads is always ticked.

Could this be fixed so it doesn't do that or is now policy to force the acceptable ads on users?

Cheers,
Banzi.

Re: Acceptable ads always enabled after update

PostPosted: Wed Aug 14, 2013 1:58 pm
by mapx
I can confirm this behaviour.

Re: Acceptable ads always enabled after update

PostPosted: Wed Aug 14, 2013 5:37 pm
by Anomymous
Looks like a careless bug. They're comparing against the Firefox version number 2.1 when the Chrome version number is still 1.x

Code: Select all
  // Add "acceptable ads" subscription for new users and users updating from old ABP versions
  var addAcceptable = (!prevVersion || Services.vc.compare(prevVersion, "2.1") < 0);
  if (addAcceptable)
  {
    addAcceptable = !FilterStorage.subscriptions.some(function(subscription)
    {
      return subscription.url == Prefs.subscriptions_exceptionsurl;
    });
  }

Re: Acceptable ads always enabled after update

PostPosted: Thu Aug 15, 2013 2:21 pm
by Wladimir Palant
Yes, looks like you are right. Internally, Chrome builds were using the same version numbers as Firefox builds until recently. This changed now but this code was forgotten. Fixed now: https://hg.adblockplus.org/adblockplusc ... 6447b2203d

Re: Acceptable ads always enabled after update

PostPosted: Fri Aug 16, 2013 12:54 pm
by Wladimir Palant
Adblock Plus 1.5.4 is out. And here is a detailed explanation of this issue: https://adblockplus.org/blog/bug-in-adb ... e-reverted