Whitelisting is broken on links with utm source appended

Everything about using Adblock Plus on Google Chrome

Whitelisting is broken on links with utm source appended

Postby delaneyc » Mon Aug 29, 2016 8:59 pm

The Adblock Plus version number: 1.12.2
The browser and browser version number: Chrome 52.0.2743.116
The computer operating system: OSX Yosemite 10.10.5
All relevant configuration details: no unusual circumstances, just a weird thing happening when coming to an article on any whitelisted site from Facebook.

The exact description of the steps that are needed to reproduce the issue
1. Whitelist a domain, eg theatlantic.com.
2. Click on a link from Facebook (with a ?utm_source= at the end)

https://scontent-lga3-1.xx.fbcdn.net/t3 ... 8851_o.jpg

The exact description of what happens and what you think is wrong
1. When you get to the page you clicked on, it shows a really odd thing: the ABP icon, greyed out (it recognizes it is disabled), but still disabling ads (it shows the count of ads disabled)
2. On refresh, it works as expected - lets ads show and recognizes the site has been whitelisted.

We (I'm a Product Manager at The Atlantic) have a message we show instead of an ad to users with ad block on. Many have been writing us saying they are getting the message even though they have already whitelisted The Atlantic - that explains why.
Last edited by delaneyc on Mon Aug 29, 2016 9:00 pm, edited 1 time in total.
delaneyc
 
Posts: 7
Joined: Mon Aug 29, 2016 8:45 pm

Re: Whitelisting broken on links with utm source appended

Postby delaneyc » Mon Aug 29, 2016 9:00 pm

(Please expand image to see issue)
delaneyc
 
Posts: 7
Joined: Mon Aug 29, 2016 8:45 pm

Re: Whitelisting is broken on links with utm source appended

Postby mapx » Mon Aug 29, 2016 9:35 pm

it works fine for me

1. whitelist theatlantic.com
2. click this link on FB or some other page
Code: Select all
http://www.theatlantic.com/business/archive/2016/08/charitable-judgment-candidate-philanthropy/497738/?utm_source=


the page is whitelisted, the ads are visible, ABP icon is grey
User avatar
mapx
 
Posts: 21947
Joined: Thu Jan 06, 2011 3:01 pm

Re: Whitelisting is broken on links with utm source appended

Postby delaneyc » Mon Aug 29, 2016 11:52 pm

Here is an example of a few links where I am seeing this issue:

Code: Select all
http://www.theatlantic.com/entertainment/archive/2016/08/rip-gene-wilder/497957/?utm_source=atlfb


Code: Select all
http://www.huffingtonpost.com/entry/3-women-share-the-moment-they-found-out-their-husbands-are-gay_us_57b62748e4b0b51733a26308?ncid=fcbklnkushpmg00000063
delaneyc
 
Posts: 7
Joined: Mon Aug 29, 2016 8:45 pm

Re: Whitelisting is broken on links with utm source appended

Postby mapx » Tue Aug 30, 2016 8:27 am

no issues here.

Disable all other extensions, keep only ABP, test again. Or, disable compeltely ABP see what happens.


You could also reset chrome, install only ABP, disable web shields (if any) in your antivirus and test again.
User avatar
mapx
 
Posts: 21947
Joined: Thu Jan 06, 2011 3:01 pm

Re: Whitelisting is broken on links with utm source appended

Postby delaneyc » Tue Aug 30, 2016 10:37 pm

Note: all of the developers in my workplace is seeing the same issue.

Here are some additional use cases for testing:
-only happening in Chrome
-not necessarily tied to utm_source, but tied to clicking on a link from another website
-it happens when you click on this link, for example: http://theatln.tc/2bPtk9V (but NOT if you have the ABP tab open in the Chrome inspector)
-Here is an image that shows the errors:
https://files.slack.com/files-tmb/T02MN ... m_1024.png


Please consider re-testing this issue. We're launching a product around ad blocking and it would be great if we could get this to work.
delaneyc
 
Posts: 7
Joined: Mon Aug 29, 2016 8:45 pm

Re: Whitelisting is broken on links with utm source appended

Postby mapx » Tue Aug 30, 2016 11:00 pm

yes, I can reproduce it now.

However, in that case, if I whitelist
theatln.tc
and even removing theatlantic.com from whitelisted domains ==> all is working fine.

It's a different behaviour from that in firefox.
User avatar
mapx
 
Posts: 21947
Joined: Thu Jan 06, 2011 3:01 pm

Re: Whitelisting is broken on links with utm source appended

Postby mapx » Tue Aug 30, 2016 11:10 pm

I reported the strange behaviour on the bug tracker:
https://issues.adblockplus.org/ticket/4386
User avatar
mapx
 
Posts: 21947
Joined: Thu Jan 06, 2011 3:01 pm

Re: Whitelisting is broken on links with utm source appended

Postby delaneyc » Tue Aug 30, 2016 11:49 pm

Thanks for reporting it. Where can I see updates as we work toward resolution?

And maybe it doesn't work if ABP perceives the link to be redirected? Like it doesn't recognize that the user is trying to get to a link from the same domain as the one that has been whitelisted?

Thank you for the suggestions on this!
delaneyc
 
Posts: 7
Joined: Mon Aug 29, 2016 8:45 pm

Re: Whitelisting is broken on links with utm source appended

Postby mapx » Tue Aug 30, 2016 11:55 pm

You can see there in the ticket when will go into reviewing phase.

As I said, it's a different behaviour in ABP for firefox, let's see what the devs will find out / say.
User avatar
mapx
 
Posts: 21947
Joined: Thu Jan 06, 2011 3:01 pm

Re: Whitelisting is broken on links with utm source appended

Postby mapx » Mon Sep 05, 2016 7:43 pm

User avatar
mapx
 
Posts: 21947
Joined: Thu Jan 06, 2011 3:01 pm

Re: Whitelisting is broken on links with utm source appended

Postby delaneyc » Tue Sep 06, 2016 4:43 pm

I see the issue is marked as resolved, but it is still happening the exact same way for me.

Steps:
1. Whitelist The Atlantic
2. Go to an Atlantic article from Facebook
3. Ads are still blocked
delaneyc
 
Posts: 7
Joined: Mon Aug 29, 2016 8:45 pm

Re: Whitelisting is broken on links with utm source appended

Postby mapx » Tue Sep 06, 2016 6:08 pm

Did you install the last dev build ? see link above (and disable the stable ABP)
User avatar
mapx
 
Posts: 21947
Joined: Thu Jan 06, 2011 3:01 pm

Re: Whitelisting is broken on links with utm source appended

Postby delaneyc » Tue Sep 06, 2016 6:49 pm

Thank you! I am seeing it working in the dev build.
delaneyc
 
Posts: 7
Joined: Mon Aug 29, 2016 8:45 pm


Return to Adblock Plus for Chrome support

Who is online

Users browsing this forum: No registered users and 15 guests