Recommended filters for Chrome block too much

Everything about using Adblock Plus on Google Chrome

Recommended filters for Chrome block too much

Postby Strulf » Tue Feb 22, 2011 9:15 pm

Interactive maps on http://www.zeit.de (like this one of north africa if you scroll down a bit: http://www.zeit.de/politik/ausland/2011 ... te-staemme) don't work if "Recommended filters for Google Chrome" are active.

Would it be able to change that?

Thank you
Strulf
 
Posts: 33
Joined: Tue Feb 08, 2011 6:13 pm

Re: Recommended filters for Chrome block too much

Postby Wladimir Palant » Thu Feb 24, 2011 1:21 pm

At least with the current development build the issue happens with plain EasyList as well, probably because now it really blocks all the doubleclick scripts. Adding an exception for doubleclick.net "fixes" the issue. No idea why everything works correctly in Firefox.
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Recommended filters for Chrome block too much

Postby MonztA » Thu Feb 24, 2011 2:05 pm

Weird, works fine with FF3 but not with FF4. If I open the link in a new tab with the latest nightly, the map loads and works but if I refresh the site after that, the map is is broken. If I open the link without sending the referrer or if I open it in the same window, the map is broken (cleared cache and cookies before testing).
MonztA
ABP IT Officer
 
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Re: Recommended filters for Chrome block too much

Postby Wladimir Palant » Thu Feb 24, 2011 2:16 pm

Ok, this seems to be a subtle bug in WebKit paired with an unsafe assumption on zeit.de, as a result we get timing issues. doubleclick scripts delay page load, this tends to mask the issue. But the problem is always there, with or without Adblock Plus.

Filed WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=55132
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Recommended filters for Chrome block too much

Postby Wladimir Palant » Thu Feb 24, 2011 2:20 pm

I think that it fails in Firefox 4 for different reasons - Firefox 4 now loads scripts that are inserted dynamically in parallel which breaks some assumptions. At least my testcase for the WebKit bug still produces the expected results in Firefox 4. So - yes, zeit.de is making unsafe assumptions.
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Recommended filters for Chrome block too much

Postby Strulf » Mon Feb 28, 2011 10:53 pm

Wladimir Palant wrote:At least with the current development build the issue happens with plain EasyList as well, probably because now it really blocks all the doubleclick scripts. Adding an exception for doubleclick.net "fixes" the issue. No idea why everything works correctly in Firefox.
Sadly, that doesn't work either. The only way to get the map to work is to unclick EasyList and the recommended filters. Worked with EasyList before though, so I don't know why it suddenly doesn't.
Strulf
 
Posts: 33
Joined: Tue Feb 08, 2011 6:13 pm

Re: Recommended filters for Chrome block too much

Postby Wladimir Palant » Tue Mar 01, 2011 8:58 am

Because you are on Adblock Plus 1.1 now which implements proper blocking, something that previously had to be compensated by the recommended filters. Without the ad scripts this page loads too fast which reveals the bug in the way the map loads.
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Recommended filters for Chrome block too much

Postby Strulf » Wed Mar 02, 2011 9:47 pm

Would it be possible then to exclude it from EasyList? It works without EasyList and I don't want to deactivate EasyList since it helps a lot on other sites. I already asked Michael of EasyList but he changed the thread there to NA so I'm not sure if he is still reading in that thread at all.

http://forums.lanik.us/viewtopic.php?f=64&t=8134
Strulf
 
Posts: 33
Joined: Tue Feb 08, 2011 6:13 pm

Re: Recommended filters for Chrome block too much

Postby Wladimir Palant » Wed Mar 02, 2011 10:13 pm

A better course of action would be contacting zeit.de and pointing out the issue in their code. If the information in the Chrome issue I filed isn't enough I can provide them with the details.
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Recommended filters for Chrome block too much

Postby Michael » Wed Mar 02, 2011 10:26 pm

I continue to read and, if necessary, respond to all posts even after having changed the topic title and have provided the following response to your request:
Michael wrote:According to Wladimir "the problem is always there, with or without Adblock Plus" due to "a subtle bug in WebKit paired with an unsafe assumption on zeit.de" and there is therefore little point in whitelisting items on this domain.
Michael
 
Posts: 1361
Joined: Sat Dec 19, 2009 1:29 pm

Re: Recommended filters for Chrome block too much

Postby Strulf » Fri Mar 04, 2011 5:58 pm

Wladimir Palant wrote:A better course of action would be contacting zeit.de and pointing out the issue in their code. If the information in the Chrome issue I filed isn't enough I can provide them with the details.
Well what should I tell them? Sorry can you please repair your site so I can block your ads again? I don't think they're gonna react to that. Besides, I'm not a developer so I can't really tell them exactly what the problem on their site is.

And I dont't see the point in NOT whitelisting Zeit.de.... It's just one site.
Strulf
 
Posts: 33
Joined: Tue Feb 08, 2011 6:13 pm

Re: Recommended filters for Chrome block too much

Postby Hubird » Sat Mar 05, 2011 1:25 am

Strulf wrote:And I dont't see the point in NOT whitelisting Zeit.de.... It's just one site.


:lol:

Then somebody else comes along and wants just one site whitelisted...
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: Recommended filters for Chrome block too much

Postby Strulf » Sat Mar 05, 2011 10:44 pm

Ok can you at least tell me what filter of EasyList exactly doesn't work with that map on zeit.de?
Strulf
 
Posts: 33
Joined: Tue Feb 08, 2011 6:13 pm


Return to Adblock Plus for Chrome support

Who is online

Users browsing this forum: No registered users and 14 guests