Webrequest

Wladimir Palant · Post by **Wladimir Palant** » Fri Sep 30, 2011 1:35 pm

@pirlouy: Actually, the Network tab of the Developer Tools already does the job. The requests showing up as "(failed)" in red are blocked.

Note that in Chrome $object and $object-subrequest are the same thing, there is no way to distinguish them.

pirlouy · Post by **pirlouy** » Fri Sep 30, 2011 1:41 pm

Ok. So indeed, I need to add

Code: Select all

@@||s.ytimg.com^$object-subrequest

in order to have videos working.

Do you know the bug (feature request) which allows to add object subrequest ? I think I saw it once... Bah, nevermind, I'll search later.

Thanks for your answer.

Wladimir Palant · Post by **Wladimir Palant** » Fri Sep 30, 2011 1:45 pm

@pirlouy: Maybe you don't need to add it. I made sure that the type properties are properly treated as equivalent: https://hg.adblockplus.org/adblockplusc ... ddd5941989 (wanted to do it anyway, current solution was only temporary). New development builds will be out in 5 minutes.

The relevant bug should be http://code.google.com/p/chromium/issue ... l?id=80230

pirlouy · Post by **pirlouy** » Fri Sep 30, 2011 9:54 pm

I've just installed latest experimental build, and now object-subrequests are not recognized anymore. From what you said, it should do the same as $object. It's not the case.

I just watched the Network tab. Ahah ! Sorry, it's too complicated/boring for a casual user like me.

I notice something else, but I think it's a webrequest API bug: Even if you block $object, Flash is launched anyway. If it's not a bug, it's a severe restriction.

Wladimir Palant · Post by **Wladimir Palant** » Fri Sep 30, 2011 10:22 pm

Yes, Chrome blocks requests on the network level which is different from Firefox. So Flash is allowed to launch but the download of its data "fails".

Could you give me an example (exact steps to reproduce) of how object subrequests are not recognized?

pirlouy · Post by **pirlouy** » Sat Oct 01, 2011 1:48 am

AB+ 1.1.4.695
chrome 16.0.891

Problematic filter:
*$third-party,script,subdocument,object-subrequest

Step:
Go on Youtube and launch a video

Expected:
object blocked, because it comes from ytimg.com and object-subrequest is the same as object

Behavior (bug):
object is not blocked, video is launched

Some clues; these filters works though:
*$third-party,script,object-subrequest
*$third-party,script,subdocument,object

lewisje · Post by **lewisje** » Sat Oct 01, 2011 2:52 am

It has been deferred yet again, to Chrome 17: http://code.google.com/p/chromium/issue ... =60101#c79

Wladimir Palant · Post by **Wladimir Palant** » Sat Oct 01, 2011 2:58 pm

@lewisje: Yes, that was to be expected actually...

@pirlouy: Works for me. You only see a black rectangle (Flash instantiated but nothing loaded), and network tab of the developer tools shows "watch_*.sfw" in red (request failed). You have the experimental build, right? It should say "Adblock Plus for Google Chrome™ (Beta) experimental build" in the extensions list.

pirlouy · Post by **pirlouy** » Sat Oct 01, 2011 8:32 pm

Frack, I do not reproduce either. :/

pirlouy · Post by **pirlouy** » Mon Oct 03, 2011 9:41 pm

Another bug; hope it will be reproductible...

If you disable AB+ thanks to the icon, things are still blocked. :/

And a request in the same time: please, offer a context menu (popup or whatever) which allows to unblock everything temporarily.

pirlouy · Post by **pirlouy** » Mon Oct 03, 2011 11:10 pm

And another one, but it might be a Webrequest API bug...

I try this filter:

Code: Select all

*$third-party,image

and I don't know if it's linked, but I think there's a link.

When I load a website, sometimes, the first display, there's no image, they are all blocked; then I reload the page, and now everything is ok. It's the first load only...

Wladimir Palant · Post by **Wladimir Palant** » Tue Oct 04, 2011 11:28 am

@pirlouy: First issue is fixed: https://hg.adblockplus.org/adblockplusc ... ee2e6a1bdf

Concerning the second issue: I tried a few sites but couldn't see the issue. That might be because I use Chrome 15 (beta), I guess that you are on Chrome 14? Edit: Then again, did that happen immediately after you installed/activated the extension? Meaning that the tab was already open when the extension became active.

pirlouy · Post by **pirlouy** » Tue Oct 04, 2011 12:49 pm

I use dev channel, so I was in 16.0.891 until today. I'm now in 16.0.899.
AB+ was already installed and activated, Chrome relaunched. So it's not linked to the first issue.

But as I said, it's not easily reproducible; for example, I did not have this behavior in these last 5 minutes. I'll edit if I reproduce.

Edit: it happened again, but this time only some images were blocked; by the way the placeholder thing is very useful (that was one of my feature request for Firefox

); combined to the "Click To Play" Chrome feature, it's great.

Wladimir Palant · Post by **Wladimir Palant** » Tue Oct 11, 2011 10:27 am

Starting with 1.1.4.701 the "no data received" messages and "broken image" placeholders should no longer appear. There is a new option "Hide placeholders of blocked elements" controlling that, it works pretty much the same as "Collapse blocked elements" in Firefox (meaning in particular that $collapse and $~collapse options on individual filters can override the global setting). I plan to rename the option in Firefox as well, the new title does a better job explaining what it does.

Anomalous · Post by **Anomalous** » Wed Oct 12, 2011 4:48 am

So it doesn't actually collapse, but returns dummy image data for blocked images? That's what I'm seeing anyway.

Adblock Plus

Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest

Re: Webrequest