Page 1 of 2

[Fixed] 1.3.0.865 doesn't hide placeholders

Posted: Sat Oct 27, 2012 6:48 am
by telegreenick
Hello,

i've noticed from the changelog
#859: 2012-10-26 15:55 +0200 Wladimir Palant
Fixed "Hide placeholders of blocked elements" feature
that you had been trying to fix this annoying problem but it still doesn't work on some websites.

When i block an element, say an image, on this website: http://hdclub.org/

Here is what i get after i refresh the page: http://i.imgur.com/kDyc3.png

It's just one example. It's absolutely the same on many other websites.

I hope you can finally fix it. It's quite annoying to switch to firefox each time i want to create a filter, because i have to hide elements instead of blocking them and creating filters in chrome is much less convinient than it is in firefox.

Re: 1.3.0.865 doesn't hide placeholders

Posted: Sun Oct 28, 2012 12:40 am
by telegreenick
No reply? Am i the only one with this problem? I don't think so...

Do you need more info from me?

Re: 1.3.0.865 doesn't hide placeholders

Posted: Sun Oct 28, 2012 4:25 am
by telegreenick
up!

Re: 1.3.0.865 doesn't hide placeholders

Posted: Sun Oct 28, 2012 11:25 am
by mapx
i can confirm it

Re: 1.3.0.865 doesn't hide placeholders

Posted: Sun Oct 28, 2012 5:13 pm
by Wladimir Palant
Confirmed and moved to the bug reports forum. For some reason it doesn't work for this image placeholder even though it should.

Edit: It's a timing issue apparently, the content script attempts to remove the placeholder too early, before it is added to the document.

Re: 1.3.0.865 doesn't hide placeholders

Posted: Sun Oct 28, 2012 5:49 pm
by Wladimir Palant

Re: 1.3.0.865 doesn't hide placeholders

Posted: Tue Oct 30, 2012 12:09 pm
by Wladimir Palant
This has been fixed now, the fix will be part of the next development build (will be out in 15 minutes).

Re: [Fixed] 1.3.0.865 doesn't hide placeholders

Posted: Tue Oct 30, 2012 2:02 pm
by TheIrreverend
Is this is the same issue which is causing this in Google Reader - http://i.imgur.com/k9J0b.png? Frame Info - http://i.imgur.com/qMs5k.png

Re: [Fixed] 1.3.0.865 doesn't hide placeholders

Posted: Tue Oct 30, 2012 3:57 pm
by Wladimir Palant
Yes, it should be the same one.

Re: [Fixed] 1.3.0.865 doesn't hide placeholders

Posted: Wed Oct 31, 2012 12:59 am
by telegreenick
Doesn't always work :/ . If you refresh the page many times or go to other pages on the same website, either the image will appear or the placeholder won't be hidden. It also doesn't hide placeholders for some images at all and has a problem with blocking flash elements.

1st case:

Site: http://www.addic7ed.com/

Filter rule:

Code: Select all

https://www.paypal.com/en_US/i/btn/btn_donateCC_LG.gif
Result after refresh of the page: http://i.imgur.com/FJNmU.jpg

Happens: every time after refresh.



2nd case:

Site: http://hdclub.org

Filter rule:

Code: Select all

http://hdclub.org/pic/uarb.jpg
(Ukrainian Flag on the right side under 3dplayers ad)

Result after first refresh of the page: http://i.imgur.com/TpAcG.jpg (as it should be)

Result after one of the next refreshes: http://i.imgur.com/Tq2l5.jpg

Happens: not every time. Randomly after refreshing the page or after moving from one page of the website to another.




3rd case(although i don't know if it's part of this problem, because ABP doesn't hide placeholders for flash ads at all):

Website: http://www.bannaz.com/ (company that sells flash banners, i think)

Filter rule:

Code: Select all

http://www.bannaz.com/images/329x327_bannerdisplay.swf
Result after refresh: http://i.imgur.com/X5POC.jpg (white space on the place where banner used to be and if you right-click on it you can see "Adobe Flash Player" context menu.

Happens: always after you refresh the page with a blocked flash banner

Re: [Fixed] 1.3.0.865 doesn't hide placeholders

Posted: Wed Oct 31, 2012 9:11 am
by MonztA
TheIrreverend wrote:Is this is the same issue which is causing this in Google Reader - http://i.imgur.com/k9J0b.png? Frame Info - http://i.imgur.com/qMs5k.png
Wladimir Palant wrote:Yes, it should be the same one.
Does not seem to be fixed: forum/viewtopic.php?p=64813#p64813

Re: 1.3.0.865 doesn't hide placeholders

Posted: Wed Oct 31, 2012 10:16 am
by Wladimir Palant
Well, anything I do here are just work-arounds for Chrome bug 97392. I hope that Google plans to fix it eventually.

That said, I think that I found a more reliable approach that should work properly even with dynamic pages like Google Reader. This change is under review: http://codereview.adblockplus.org/8741005/

Re: 1.3.0.865 doesn't hide placeholders

Posted: Wed Oct 31, 2012 1:02 pm
by telegreenick
Thanks, it's much better now. Although "1st case" and "3rd case" from this forum/viewtopic.php?f=11&t=11337&p=64836#p64805 post still exist. I mean that some placeholders aren't hidden for some images and for blocked flash banners.

Also there is a case when some images aren't blocked at all. I don't know if it has to do with this topic or not.

Hot to reproduce it.

Go to http://liveonsat.com/

Try to block these 2 banners:
1. http://i.imgur.com/7cZvG.jpg
2. http://i.imgur.com/oYAln.jpg

You'll end up with these 4 filters for them:

Code: Select all

http://www.liveonsat.com/images/430 x 88 WANT 3PM GAMES.jpg
http://www.liveonsat.com/images/120 X 240 WANT 3PM GAMES.jpg
http://www.liveonsat.com/images/120X240WANT3PMGAMES.jpg
http://www.liveonsat.com/images/430x88WANT3PMGAMES.jpg
Refresh the page a few times and you'll still see those banners sometimes. Clearing the cache in Chrome doesn't help.

Re: 1.3.0.865 doesn't hide placeholders

Posted: Wed Oct 31, 2012 2:37 pm
by Wladimir Palant
@telegreenick: Your first scenario (an image button) should be covered by http://codereview.adblockplus.org/8722030/. As to Flash banners - hiding these is pretty impossible unfortunately.

As to not being able to block these images - that's a different and unrelated issue, please create a new forum topic for it. The problem there is really that what you are trying to add isn't the real address of the image, spaces are changed into %20 automatically. Still, Adblock Plus suggests wrong filters in this case which isn't great.

Re: 1.3.0.865 doesn't hide placeholders

Posted: Wed Oct 31, 2012 3:02 pm
by telegreenick
Thank you, Wladimir Palant!!!

I will create a new topic about the last issue.