Page 1 of 1

[Fixed] ABP blocks ads when domain is whitelisted.

PostPosted: Mon Oct 29, 2012 12:45 pm
by nobodyfamous
On any site with Google Adsense, ABP is blocking the ads even when the site is whitelisted. Sometimes they appear for a second then disappear. Also, the blank space where the ad is remains, unlike if ABP is turned on for that site it removes the space.

I'm guessing it's because the ads load in an iframe? So ABP is blocking googlesyndication.com or whatever, and still blocking it when the parent site is something else.

Re: ABP blocks ads when domain is whitelisted.

PostPosted: Mon Oct 29, 2012 8:13 pm
by Crits
I can reproduce your problem on Google Chrome with ABP 1.3
Test page: http://www.malekal.com/ (left column of the page)

(Note that this problem normally doesn't occur with Firefox)

As I have always been using Firefox, I don't know if this is a regression brought by ABP 1.3 or if the problem already existed before the 1.3 version.
I guess this will be fixed soon by the dev.

Re: ABP blocks ads when domain is whitelisted.

PostPosted: Mon Oct 29, 2012 8:32 pm
by rollex
This bug is only since the last update. Before it was working fine.
I had open few days ago a post about it : viewtopic.php?f=11&t=11339

Re: ABP blocks ads when domain is whitelisted.

PostPosted: Mon Oct 29, 2012 9:20 pm
by oleiros
Same here. After update, the adsense from my news site (http://www.efe.com) is blocked even with the domain included in whitelist. No issues with FF.

Re: ABP blocks ads when domain is whitelisted.

PostPosted: Tue Oct 30, 2012 9:42 am
by Wladimir Palant
I think it's a caching issue. A fix is already under review: http://codereview.adblockplus.org/8691076/

Re: ABP blocks ads when domain is whitelisted.

PostPosted: Tue Oct 30, 2012 1:06 pm
by Wladimir Palant
The caching issue will be fixed in the next development build (will be out in 15 minutes). It would be nice if somebody could install the development build and verify that the issue here is fixed as well.

Re: ABP blocks ads when domain is whitelisted.

PostPosted: Tue Oct 30, 2012 1:36 pm
by Crits
Reporting as fixed on Chrome 22.0.1229.96 m, with the latest development build!

Test pages:
http://www.malekal.com/
http://www.hellokitty.fr/

Re: [Fixed] ABP blocks ads when domain is whitelisted.

PostPosted: Wed Oct 31, 2012 9:58 am
by rollex
I confirm it's ok on Chrome 22.0.1229.94 m with the latest development build.
Test page : http://vr-annexe.akroweb.fr/

Re: [Fixed] ABP blocks ads when domain is whitelisted.

PostPosted: Thu Nov 01, 2012 7:19 am
by krunk
Glad to see this has been fixed! Great job guys!

Re: [Fixed] ABP blocks ads when domain is whitelisted.

PostPosted: Wed Nov 07, 2012 6:41 pm
by xkz
First, sorry for my bad english xD

I am webmaster of a small web site and we support the not-intruder advertising (non-massive adversiting). We have only one advertisement in a wings to survive. Some of our users want to support us, and because of it they deactivate adblockplus in our web. Nevertheless, for a little time, our visitors have informed us that they cannot visualize the advertisement when they add the web to the white list.

I've checked it from Chrome Updated and ABP 1.3

Thank you,

Regards

Re: [Fixed] ABP blocks ads when domain is whitelisted.

PostPosted: Wed Nov 07, 2012 6:45 pm
by MonztA
It was fixed in Adblock Plus for Chrome 1.3.1 which was released some hours ago. Can you test it with the new version?

Re: [Fixed] ABP blocks ads when domain is whitelisted.

PostPosted: Wed Nov 07, 2012 6:55 pm
by Guest
MonztA wrote:It was fixed in Adblock Plus for Chrome 1.3.1 which was released some hours ago. Can you test it with the new version?


Right! Is working now!

But I can't update from Chrome :S I have had to uninstall ABP and download again. Is possible to update it automatically?

Thanks!

Re: [Fixed] ABP blocks ads when domain is whitelisted.

PostPosted: Wed Nov 07, 2012 7:06 pm
by MonztA
Sure, all users on 1.3 will get the 1.3.1 update in the next hours (or so). You can tick "Developer Mode" in the extension tab in Chrome. It will show a button that allows searching for updates of your extension(s).

Re: [Fixed] ABP blocks ads when domain is whitelisted.

PostPosted: Wed Nov 07, 2012 8:28 pm
by xkz
MonztA wrote:Sure, all users on 1.3 will get the 1.3.1 update in the next hours (or so). You can tick "Developer Mode" in the extension tab in Chrome. It will show a button that allows searching for updates of your extension(s).

Thank you so much and sorry for my ignorance ;)