Page 1 of 1

[Fixed] Memory Leaks in ABP 1.3 for Chrome

Posted: Tue Oct 30, 2012 7:32 pm
by chordoflife
I've been experiencing memory leaks in ABP 1.3 for Chrome, running chrome 22.0.1229.94 m and no other extensions. It's especially noticeable if you leave a tab open and use it over time. It happens on every page, but it happens faster if you're switching through pages with more resources. Chrome's memory usage goes up gradually in a tab until the browser is using a very large amount of ram:

(760 MB of ram in PID 5536)
Image

This behaviour disappears after disabling the Adblock Plus extension.

Re: Memory Leaks in ABP 1.3 for Chrome

Posted: Wed Oct 31, 2012 10:05 pm
by NeVeRLiFt
Same here, seeing memory leak bad with Adblock+ 1.3
No other extensions or addons used, and during testing.

Turning off Adblock+ 1.3 stops the memory leak, even during the test if you disable it the memory use stops, enable it and watch memory climb until it crashes.

Please fix this memory leak.

Re: Memory Leaks in ABP 1.3 for Chrome

Posted: Wed Oct 31, 2012 10:23 pm
by NeVeRLiFt
Using Firefox v16 with Adblock+ 1.3 is fine so guess I have to stop using Chrome till Adblock+ works with it again.

Re: Memory Leaks in ABP 1.3 for Chrome

Posted: Wed Oct 31, 2012 10:42 pm
by chordoflife
NeVeRLiFt wrote:Using Firefox v16 with Adblock+ 1.3 is fine so guess I have to stop using Chrome till Adblock+ works with it again.
There's another adblock extension for chrome that works moderately well. I started using that in the meantime.

Re: Memory Leaks in ABP 1.3 for Chrome

Posted: Thu Nov 01, 2012 12:30 am
by NeVeRLiFt
I'm using the development build v1.3.0.884 and the memory leak is gone.

So please whatever you did with v1.3 to cause the memory leak fix it.

The v1.3.0.884 dev build is working 100% and no memory leak.

Re: Memory Leaks in ABP 1.3 for Chrome

Posted: Thu Nov 01, 2012 4:38 pm
by MrGuest
I'm using this extension with SRWare Iron 22.0.1250.0. I had no problems whatsoever with previous version. Since update to version 1.3, ABP is causing huge memory leaks leading Windows to go out of memory and crashing browser's open tabs.

Re: Memory Leaks in ABP 1.3 for Chrome

Posted: Fri Nov 02, 2012 12:37 pm
by fhd
Seems to be the same issue as this one.

Could you try to remove ABP and reinstall it from the Chrome Web Store?

Re: Memory Leaks in ABP 1.3 for Chrome

Posted: Fri Nov 02, 2012 4:27 pm
by chrodoflfie
fhd wrote:Seems to be the same issue as this one.

Could you try to remove ABP and reinstall it from the Chrome Web Store?
I removed and reinstalled ABP as you requested. It doesn't seem to be leaking for me any more. I'm glad. :)

Re: Memory Leaks in ABP 1.3 for Chrome

Posted: Fri Nov 02, 2012 6:48 pm
by kbrint
FWIW I was able to prevent this leak by un-checking "Disable inline text ads".

Removing and re-installing the extension has the same effect... "Disable inline text ads" is unchecked afterwards.

So, therein lies the leak, and that explains why remove and reinstall "fixes" it.

HTH.

-kb

Re: Memory Leaks in ABP 1.3 for Chrome

Posted: Mon Nov 05, 2012 9:57 am
by fhd
kbrint wrote:FWIW I was able to prevent this leak by un-checking "Disable inline text ads".

Removing and re-installing the extension has the same effect... "Disable inline text ads" is unchecked afterwards.

So, therein lies the leak, and that explains why remove and reinstall "fixes" it.
Thank you very much, that is indeed the issue! We're probably going to remove that feature altogether, considering that we don't even seem to need it.

Re: Memory Leaks in ABP 1.3 for Chrome

Posted: Tue Nov 06, 2012 2:04 pm
by fhd
I've removed the option, shouldn't happen anymore with the upcoming release.

Re: [Fixed] Memory Leaks in ABP 1.3 for Chrome

Posted: Wed Nov 14, 2012 8:17 am
by NeVeRLiFt
Thank you for finding and fixing this so fast.

Re: [Fixed] Memory Leaks in ABP 1.3 for Chrome

Posted: Mon Dec 10, 2012 12:19 am
by darkocean
Think that's bad. try fire fox lately. it's memory leek is getting worse and worse. along with the add-block pluss add on driving the memory up past 1gb!! i finally had to just take out all my addons.n or i can't even type in text fields and browse the net. I am serously thinking about using google chrome. Anything has to be better then this!