I searched this forum for "preview", but that didn't turn up anything. Can anyone confirm this?
When you hover the mouse cursor over an image resource in the Blockable Items pane, you're supposed to see a preview of that image. I get the usual tooltip with various info, but no preview. I've verified that extensions.adblockplus.previewimages is still at its default setting, true.
It seems to be a problem for all images, regardless of size or format, or whether any filters whatsoever apply to them.
Firefox 18.0
Adblock Plus 2.2.1
Blockable Items - no image preview
Re: Blockable Items - no image preview
Is this related to that?
forum/viewtopic.php?t=6012
forum/viewtopic.php?t=6012
Author of Liste FR, an ad-blocking subscription for French websites
- Gingerbread Man
- Posts: 1339
- Joined: Fri Aug 12, 2011 5:28 am
Re: Blockable Items - no image preview
Re: Blockable Items - no image preview
Well, I can actually reproduce the bug. No preview on no image whatsoever (even if the blockable item list is opened before loading the page), so it's indeed not related to the aforementioned discussion.
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0
Adblock Plus 2.2.2a.3610
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:19.0) Gecko/20100101 Firefox/19.0
Adblock Plus 2.2.2a.3610
Author of Liste FR, an ad-blocking subscription for French websites
Re: Blockable Items - no image preview
It happens to me once i upgrade past Firefox 17, if I go to 18 or 19, it will not longer show image previews, but if i go back to Firefox 17, it fixes it
- Gingerbread Man
- Posts: 1339
- Joined: Fri Aug 12, 2011 5:28 am
Re: Blockable Items - no image preview
No change with Adblock Plus 2.2.2, in case anyone was wondering.
Re: Blockable Items - no image preview
Yeah, still no fix, and I really dont want to just stick on Firefox 17 forever simply because this little bug has yet to be fixed.
Re: Blockable Items - no image preview
This issue is caused by Gecko 18 borking most usage of openCacheEntry(). This can be fixed by modifying sidebar.js to use asyncOpenCacheEntry() instead of openCacheEntry() . Here's diff output for a patch:
Note that this was applied to a modified Adblock Plus 2.1.2 and not the latest release 2.4 so be careful about line numbers when using this, but you get the idea.
Code: Select all
294,296c294,313
< try {
< var descriptor = cacheSession.openCacheEntry(item.location, Ci.nsICache.ACCESS_READ, false);
< descriptor.close();
---
> var descriptor = null;
> let cacheListener = {
> onCacheEntryAvailable: function(desc, accessGranted, status)
> {
> if (!desc)
> {
> showPreview = false;
> return;
> }
> descriptor = desc;
> descriptor.close();
> // Show preview here since this is asynchronous now
> // and we have a valid descriptor
> E("tooltipPreview").setAttribute("src", item.location);
> },
> onCacheEntryDoomed: function(status) {}
> };
> try
> {
> cacheSession.asyncOpenCacheEntry(item.location, Ci.nsICache.ACCESS_READ, cacheListener);
298c315,317
< catch (e) {
---
> catch (e)
> {
> // Not sure we can get here, but just in case...
299a319
> Cu.reportError(e);
306d325
< E("tooltipPreview").setAttribute("src", item.location);
Re: Blockable Items - no image preview
This has now been fixed (see https://hg.adblockplus.org/adblockplus/rev/e39995e07eb9). You can either try it in the latest development builds or wait for the next release.
Thanks everyone for your patience.
Thanks everyone for your patience.