[Fixed] ABP for Chrome: popup blocking not efficient enough

[MonztA]

This popup "http://hamster.cc/?log=51" on http://www.movie-blog.org/ (appears if you click on "ENTER / EINTRITT") is not blocked despite the ||hamster.cc^$image,~image,popup,domain=movie-blog.org rule in EasyList Germany. Adding ||hamster.cc^$popup as a rules also does not work.

Same on http://g-stream.in/ if you just click anywhere for the first time this popup "https://www.tipico.com/de/l//Bundesliga ... teId=21920" appears which should be blocked via ||tipico.com^*?affiliateid=$popup,third-party.

Works fine though on http://www.sendspace.com/file/ypz38z if you click on "Click here to start download from sendspace" (blocked by /sendspace-pop.$popup,domain=sendspace.com).

[Wladimir Palant]

I could reproduce that issue on movie-blog.org. The problem is really that the pop-up is opened while the original page navigates away - Chrome no longer reports an opener then, at least not in chrome.tabs.onCreated. A content script could still recognize it as a pop-up - window.opener property is set. But a content script doesn't have enough privileges to find out the URL of the opener.

[Wladimir Palant]

Fix is under review: http://codereview.adblockplus.org/9496013/

[Wladimir Palant]

Next development build should work fine: https://hg.adblockplus.org/adblockplusc ... a217baf5e2

[MonztA]

Thanks! Confirmed working on movie-blog.org.

However, found another one where it is not blocked: 4fuckr.com (NSFW) click on the dark background when page finishes loading. Should be blocked by ||4fuckr.com/api.php$image,~image,popup but is not.

Anything that can be done there?

E: go to http://goldesel.to/, click on any entry and then click on the "Highspeed Download" link. The new tab/window is blocked in FF by ||friendlyduck.com^$image,~image,popup,third-party but not in Chrome.

E2: go to http://364e9918.linkbucks.com/, click the white space. The new tab/window is blocked in FF by ||linkbucks.com/|$image,~image,popup,domain=allanalpass.com|any.gs|dyo.gs|linkbucks.com|qqc.co|ultrafiles.net|yyv.co but not in Chrome.

E3: go to http://www.mofunzone.com/, click on the dark background. The new tab/window is blocked in FF by |http:$image,~image,popup,third-party,domain=extreme-board.com|filepost.com|load.to|mofunzone.com|xtshare.com but not in Chrome.

[Wladimir Palant]

https://hg.adblockplus.org/adblockplusc ... 9ca5f03afd seems to have fixed all these issues (new development build will be available in 30 minutes).

[MonztA]

Thanks! Looks good now.

[mapx]

go here
http://isohunt.com/torrents/?ihq=duck

and then click anywhere in the page or choose a torrent, stills opens a popup window

or ... it needs some other popup filter (because the popup exists also in firefox)

[mapx]

in the blockable items in firefox I can see an item about:blank (pop-up window type)

[MonztA]

No popup for me in both browsers.

Could you submit an issue report and post the link here?

[mapx]

https://reports.adblockplus.org/e3d049b ... 5ff86e17d0

[MonztA]

Thanks, added to EasyList: https://hg.adblockplus.org/easylist/rev/d14c155b6357

[mapx]

now ...

firefox intercepts popup window and - but with some delay - close the popup

chrome can't block the popup
to block the popup I blocked isohits ==> ||isohits.com (to block the script http://isohits.com/apu.php?zoneid=*&lim=* )

[MonztA]

Whoops, missed the script. Thanks! https://hg.adblockplus.org/easylist/rev/db03db0d9e68