[firefox] Find does not work in the Filter Preferences

[Guest]

Find bar does not appear when I press the Find button in the Filter Preferences window. Keyboard shortcut for Find also does nothing. Other buttons work as expected. ABP 2.4 on FF 27 beta.

[mapx]

I can confirm ==> broken feature

[yfdyh000]

TypeError: this.browser.finder is undefined findbar.xml:481, at this.browser.finder.caseSensitive = caseSensitive;
The cause by http://hg.mozilla.org/mozilla-central/rev/295578d99074

[happysurf]

Confirmed also in the last Aurora and Nightly versions.

[guest]

Here's diff output for a patch to chrome/content/ui/filters-search.js that restores basic findbar functionality (but you'll see the problem with this as soon as you try it):

Code: Select all

186a187,212
> 
> 	// Gecko 27+ compatibility code
> 	_finder: null,
> 	_lastSearchString: null,
> 	finder:
> 	{
> 		searchString: null,
> 		caseSensitive: false,
> 		addResultListener: function(){},
> 		removeResultListener: function(){},
> 		highlight: function(){},
> 		enableSelection: function(){},
> 		fastFind: function(searchString, linksOnly)
> 		{
> 			this.searchString = searchString;
> 			return FilterSearch.search(this.searchString, 0, this.caseSensitive);
> 		},
> 		findAgain: function(findBackwards, linksOnly)
> 		{
> 			return FilterSearch.search(this.searchString, findBackwards ? -1 : 1, this.caseSensitive);
> 		},
> 		focusContent: function()
> 		{
> 			return FilterSearch.fakeBrowser.contentWindow.focus();
> 		},
> 	},

Based on the linked mozilla revision, tested in yesterday's nightly, should work in others.

[LouCypher]

This has been reported before
forum/viewtopic.php?f=11&t=18051

[kirchwitz]

Now that Firefox 27 has been officially released, lots of users are affected by this bug. Without "Find", management of custom filter rules is difficult, well, actually it's impossible. I have read through the Bugzilla tickets and it looks like the add-ons have to be fixed (not Firefox). Will there be a fix for AdBlockPlus?

[Endor]

When will this be fixed, has this to be fixed in Adplockplus , or in Firefox self?
When I have understand it the right way, it has to be fixed on Adblockplus.
I hope this will not forgotten or ignored.
Cheers
Endor

[kirchwitz]

Because of the non-working "Find" functionality, the management of own filters not only stopped working in Firefox but also in recent releases of SeaMonkey (well, similar code base).

Does anybody know if AdBlockPlus "patterns.ini" is compatible with alternative ad-blockers like AdBlock Edge? Or does AdBlock Edge have the same problem as it is based on AdBlockPlus?

[mapx]

edge is only a copy of ABP
the find bug is a firefox one but it seems they (firefox) ask to the authors (of addons) to make a change ..

[Samson0]

For me it's totally the same problem like kirchwitz explained in his first posting (Feb 08, 2014):

I use Firefox 27.0.1 and everything works fine with ABP, till I updated the ABP add-on to the latest version 2.5.1.
From this moment on I noticed, that the "Find" option (the button as well as the key-shortcut Strg+F) in the Filter Preferences doesn't work anymore.
Whereas at an other computer of me, with (NOT updated) ABP version 2.4.1, the "Find" functionality works fine like everytime before.

So for me it's clear, the reason is to be found at the ABP add-on's latest update.

May I ask the ABP developers to fix this bug please? Because, like kirchwitz mentioned, it's pretty difficult to manage custom filter rules as well as do research for new filter suggestions for the known filterlists without the "Find" option.

Thank you very much for your efforts

[findnotworking]

Feature is broken in Firefox 27.0.1 on Arch Linux.

[ff_adept]

"Find" button already broken at least 6 months in firefox nightly.

[wck604]

this problem has been around since January and still hasn't been fixed?

[mapx]

Support the new findbar API ==> patch under review
http://codereview.adblockplus.org/5938722247802880/