Adblock safari blocks share icon in ownCloud cal/contact app

Everything about using Adblock Plus on Safari
Post Reply
tpn
Posts: 4
Joined: Thu Feb 25, 2016 5:52 pm

Adblock safari blocks share icon in ownCloud cal/contact app

Post by tpn »

Hi there,

I'm one of the developers working on the new ownCloud contact and calendar applications (JS based frontends to the *dav backends in ownCloud: https://github.com/owncloud/contactsrework & https://github.com/owncloud/calendar-rework).

It appears that in safari 9.0.3, adblock 1.10.2 blocks the sharing icons for addressbooks and calendars. The markup is here: https://github.com/owncloud/calendar-re ... hp#L34-L40 and https://github.com/owncloud/contactsrew ... html#L4-L8). Both of these applications are being developed using AngularJS.

How can we address this issure so that the icon is available to users with AdBlock Plus installed? I can't find the debugger like is available in Firefox to see what sections are being blocked. How can I help debug this?

Cheers,
Tom
User avatar
mapx
Posts: 21940
Joined: Thu Jan 06, 2011 2:01 pm

Re: Adblock safari blocks share icon in ownCloud cal/contact app

Post by mapx »

Did you test also in firefox / chrome using the same filter lists ?
Example page using that app ?
tpn
Posts: 4
Joined: Thu Feb 25, 2016 5:52 pm

Re: Adblock safari blocks share icon in ownCloud cal/contact app

Post by tpn »

Yes. I remembered I hid the ABP button. Having found the settings page I tried disabling the lists of rules until I found that 'Fanboy's Social Blocking List' seems to block the icon, despite ABP saying '0 blocked on this page'?

Unfortunately ownCloud is a self hosted solution so I can't get you a URL to the page easily. Would a complete copy of the page's html help?

Cheers,
Tom
tpn
Posts: 4
Joined: Thu Feb 25, 2016 5:52 pm

Re: Adblock safari blocks share icon in ownCloud cal/contact app

Post by tpn »

For reference, this is also being tracked here: https://github.com/owncloud/calendar-rework/issues/235
User avatar
mapx
Posts: 21940
Joined: Thu Jan 06, 2011 2:01 pm

Re: Adblock safari blocks share icon in ownCloud cal/contact app

Post by mapx »

If you get the same issue in firefox, click ABP icon, open blockable items list, and you'll see the triggered filter from fanboy's social list.

In ABP for chrome the count number does not contain the triggered hiding filters (but only the blocking ones).

Social list is not a default list (as easylist), but if you consider those icons aren't social stuff and if you can reproduce the issue in chrome / firefox (so, it isnt a safari problem) you can report the issue directly at easylist support forum: http://forums.lanik.us/

Anyway you have to provide a real test page, so the subscriptions authors be able to reproduce / test your issue.
tpn
Posts: 4
Joined: Thu Feb 25, 2016 5:52 pm

Re: Adblock safari blocks share icon in ownCloud cal/contact app

Post by tpn »

Thanks mapx.

Reproduced in Firefox and Chrome. Blockable items shows that the offending rule is `##.icon-share` in the `Fanboy's Social Blocking List`.

Reported on the Easylist forum, will cross post the link when approved.

Cheers for your help,
Tom
Post Reply