need help with a filter

[E-TARD]

I'm on firefox v44.0
Adblock Plus v2.7.1

There is a site that has a download button
that is hooked into clkrev.com
I make my own big list of filters
and clkrev.com is in there
and I have Adblock Plus Pop-up Addon set to block all pop up's.
Yet when I click the button I get a pop going to clkrev.com & that takes me to some ad junk site.

My ? is how would I go about making a filter that will work on this?

Code: Select all

				<td colspan="3"align="center">
					<br><br>
						
							<input type="hidden" name="down_script" value="1">
<!-- 							<input type="submit" id="btn_download" value="Download File"> -->
							<input type="submit" id="btn_download" value="Download File" onclick="window.open('http://clkrev.com/adServe/banners?tid=UPLDL&action=r','_blank')">
						
</Form>
					<br><br>
				</td>

[mapx]

which is the site and how to reproduce the issue ?

[E-TARD]

I can't post the link that I'm on because the website is a file dump site that I use a lot (as a free user)
and I'm sure adblockplus.org would not be happy about me posting that here.

but what I can give you is the domain of the site http://uploadrocket.net/ & you can U/L a file & then try to download it or find a link to a file (it's easy, use google) & then you will be able to reproduce the issue.

It happens when I click the "Download File" button
I have blocked all .js files & still i get the pop-up. I have got to the point of blocking clkrev.com domain on my dd-wrt router with the Dnsmasq.
This stops clkrev.com from taking me to some website (most of them r drive by D/Ls) that does not stop the pop-up but keeps me safe

[mapx]

http://uploadrocket.net/7kki8hzdm4k8

using the link above I can't reproduce the issue
you can pm me your link

[E-TARD]

the link you have there works on me.
click the free download button,
it happens at the captcha page
when I click the "Download File" button i get the pop-up

Line 784

Code: Select all

			<tr>
				<td colspan="3"align="center">
					<br><br>
						
							<input type="hidden" name="down_script" value="1">
<!-- 							<input type="submit" id="btn_download" value="Download File"> -->
							<input type="submit" id="btn_download" value="Download File" onclick="window.open('http://clkrev.com/adServe/banners?tid=UPLDL&action=r','_blank')">
						
</Form>
					<br><br>
				</td>
			</tr>

[lewisje]

It's not obvious, but to block popups with ABP, you need to use a filter with the $popup option, so try this: ||clkrev.com^$popup

If you have a generic filter like ||clkrev.com^ go ahead and keep it, because that isn't a desirable site anyway, but add the one above.

[mapx]

already in easylist
||clkrev.com^$popup,third-party

[E-TARD]

LOL mapx I don't use easylist

I make my own big list of filters
and clkrev.com is in there

My list is 298KB with 18017 lines
it's a hobby I work on when I'm board
Someday I will to post my list on my site, for others to use or add to there lists.

@lewisje thank you so much for ^$popup I so forgot all about that LOL
yes you were right all I had was ||clkrev.com^ in my list

it would seem they have changed it now I wonder if it had anything to do with this post.

Code: Select all

		<tr>
				<td colspan="3"align="center">
					<br><br>
						
							<input type="hidden" name="down_script" value="1">
<!-- 							<input type="submit" id="btn_download" value="Download File"> -->
							<input type="submit" id="btn_download" value="Download File" onclick="window.open('http://0427d7.se/?placement=402340&redirect','_blank')">
						
</Form>
					<br><br>
				</td>
			</tr>

& ||427d7.se^ is in my list but not with ^$popup.
I will add ^$popup with 0427d7.se as well
What a cat & mouse Game

[E-TARD]

I have one more filter ?

I have looked over filter-cheatsheet
& filters <-(could have been written better)

So if I added something like this
||some-domain.com^$* would that cover almost everything?
can you use a star after the $ ?
or what format would cover everything for one domain?

I ask because almost all the domains in my list look like this

• ||teracreative.com^
  ||moceanmobile.com^
  ||mobpartner.mobi^
  ||mocean.mobi^
  ||budgetedbauer.com^
  ||atticwicket.com^
  ||ookla.com^
  ||affilize.com^
  ||nativly.com^

and what about things that run on other ports like :8080

[lewisje]

Generally, if you don't specify an option or even the $ then it means "all request types, on all domains, but not popup blocking", so your $* idea is similar to just leaving out the options.

However, if you want the popup-blocker to be used, you do need the $popup option explicitly; if you want to block content from a certain URL pattern and block popups that open URLs from that pattern, you'll need two filters:

Code: Select all

||example.com^
||example.com^$popup

[E-TARD]

@lewisje
I see what your saying & that helps.

Thank you so much for the reply.

[E-TARD]

grr this website is a pain because they keep changing URL of there ads.


but if you block this it helps
uploadrocket.net##DIV[style="z-index:2001;position:relative;"] don't how long it will be before they change that as well.
just letting everything know because many of the popup ads from this site are drive by downloads.