Page 1 of 1

[Done] Removing "Block in local pages"

PostPosted: Fri Jan 05, 2007 4:33 pm
by Wladimir Palant
I have just extended the definition of "local pages" to data: and javascript: URLs to make sure images in those can be blocked as well (greetings to Yahoo). Given this, does the option "Block remote ads in local pages" still make sense? It seems that it should be always switched on, I don't see any reasons why one would switch it off. The original idea was that local pages should be treated as special since you open them from your disk and they are under your control. However, this special treatment seems to be unjustified.

I would remove both the visible option in the user interface and the preference in about:config. Then I could kill the "Not a remote page" message in the sidebar since it is basically the same old "No blockable items" now. Any reason why I shouldn't do this?

PostPosted: Fri Jan 05, 2007 5:23 pm
by gogoban
I do not see a problem. I have it on all the time without issues. And if someone has problems, he can whitelist a local page.

What is the (technical) definition of a local page? file://? Or special IP (127.0.0.1)? Or is it something Firefox defines itself?

PostPosted: Fri Jan 05, 2007 5:40 pm
by Wladimir Palant
Technically it is everything you have in extensions.adblockplus.localschemes which is mostly file:// and a few mail schemes. Starting with Adblock Plus 0.7.2.4 it will be data: and javascript: as well - while you shouldn't be able to block data: and javascript: URLs, blocking remote images in them should be possible.

PostPosted: Fri Jan 05, 2007 11:15 pm
by ziutek
Go ahead. This option never made much sense - the fact that a file is local does not in any way imply that it should be trusted more.

PostPosted: Sat Jan 06, 2007 11:11 am
by sheepy
I'd say no special treatment. I occasionally grab reference sites since it's faster to browse them offline. And sometimes I may want to block their banner / logo to maximise content area.

PostPosted: Sat Jan 06, 2007 5:56 pm
by rick752
The ads should just be blocked either way (local or online). You could always just disable ABP if you had a need otherwise.

PostPosted: Mon Jan 08, 2007 3:20 pm
by Peng
I agree with removing it. Whoever doesn't want to block ads in local pages for some reason can whitelist them.

PostPosted: Mon Jan 08, 2007 7:41 pm
by IceDogg
I too agree. Remove it, whitelist if you need to see the ads on pages your have stored or such. JMO

PostPosted: Mon Jan 08, 2007 8:04 pm
by Stupid Head
Another vote for removing it. I'm all for simplifying.

PostPosted: Mon Jan 08, 2007 8:14 pm
by ecjs
Yep.

PostPosted: Mon Jan 08, 2007 8:24 pm
by Wladimir Palant
It seems we are unanimous on this. I will remove this option them.

PostPosted: Tue Jan 30, 2007 2:26 pm
by Wladimir Palant
Done, this option has been removed in the current development build.