[Done] more obvious icon for "Enabled"

Various discussions related to Adblock Plus development

[Done] more obvious icon for "Enabled"

Postby Wladimir Palant » Wed Apr 25, 2007 1:14 am

Bug 16891 complains that it is not obvious that you can disable filters by clicking in the "Enabled" column. A checkmark should be more obvious than a green dot. So I made a user style for this and would like to know what you think about it. Here is how it looks like:

Image
Last edited by Wladimir Palant on Thu Oct 30, 2008 12:16 pm, edited 1 time in total.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Opinions requested: more obvious icon for "Enabled&

Postby chewey » Wed Apr 25, 2007 1:20 am

Neat. :-)

What about colour coding?
I'm unsure myself about that at the moment, but I think
making the checkmarks green may be a nice addition
User avatar
chewey
 
Posts: 501
Joined: Wed Jun 14, 2006 10:34 pm
Location: somewhere in Europe

Postby Wladimir Palant » Wed Apr 25, 2007 1:23 am

I have my doubts about that...
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Josh » Wed Apr 25, 2007 1:31 am

The checkmark looks good to me. How about using a red X of some kind for the disabled icon?
Josh
 

Postby chewey » Wed Apr 25, 2007 1:35 am

That could be misinterpreted as "this item is blocking".
User avatar
chewey
 
Posts: 501
Joined: Wed Jun 14, 2006 10:34 pm
Location: somewhere in Europe

Postby Stupid Head » Wed Apr 25, 2007 1:53 am

It might conflict with some themes. Here are some comments for a userstyle that does the opposite.
What, me worry?
User avatar
Stupid Head
 
Posts: 214
Joined: Sat Aug 26, 2006 8:11 pm
Location: USA

Postby Wladimir Palant » Wed Apr 25, 2007 2:21 am

The main problem with Stylish is that it doesn't have an icon for the "disabled" status - and recognizing a *missing* checkmark is hard.

If we look at themes with black background, maybe we should make the color of the checkmark somewhat greenish as chewey suggests. The correct solution would be to set a fixed background color for the tree but I am afraid people will not like it.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Opinions requested: more obvious icon for "Enabled&

Postby rick752 » Wed Apr 25, 2007 4:28 am

chewey wrote:I think making the checkmarks green may be a nice addition


I agree with chewey. The green makes it easier to spot a disabled filter when you are scanning the list.
User avatar
rick752
 
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA

Postby rick752 » Wed Apr 25, 2007 4:44 am

Addition:
The inactive 'gray bars' themselves will not help much especially if you are using a Noia theme.

Image

I would definitely be looking for a color cue at this point.
User avatar
rick752
 
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA

Postby Alan » Wed Apr 25, 2007 10:23 am

I like the new version with the check mark just like it is. The meaning is now obvious, even to a colorblind person. I suspect that abandoning a color cue might make it more compatible with various themes too. Good work!
Alan
 
Posts: 289
Joined: Sat Feb 10, 2007 9:47 pm
Location: Colorado, USA

Postby Stupid Head » Wed Apr 25, 2007 11:27 pm

Alan wrote:The meaning is now obvious, even to a colorblind person. I suspect that abandoning a color cue might make it more compatible with various themes too.

That's assuming the background is light. If it is dark, then it'll be hard to see regardless of how good your vision is.

I like the checkmark, but I think it should be some color other than black.
What, me worry?
User avatar
Stupid Head
 
Posts: 214
Joined: Sat Aug 26, 2006 8:11 pm
Location: USA

Postby Wladimir Palant » Thu Apr 26, 2007 12:12 am

Ok, let's have green checkmarks for comparison:

Image

And the same thing with black background, just to see what it looks like:

Image

Anybody know themes with green background? :)
Last edited by Wladimir Palant on Thu Apr 26, 2007 1:56 am, edited 1 time in total.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby rick752 » Thu Apr 26, 2007 1:32 am

Even that small little bit of green just makes the eye see it a little better, imo. Even if you are color blind, it still should look slightly different I would think.
Anybody know themes with green background? :smile:

Irish Pimpzilla? :lol:
User avatar
rick752
 
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA

Postby chewey » Thu Apr 26, 2007 1:48 am

rick752 wrote:Even that small little bit of green just makes the eye see it a little better, imo. Even if you are color blind, it still should look slightly different I would think.

Yep, I agree.
User avatar
chewey
 
Posts: 501
Joined: Wed Jun 14, 2006 10:34 pm
Location: somewhere in Europe

Postby Wladimir Palant » Thu Apr 26, 2007 1:57 am

But the selected row is a problem now. I replaced the image in the post above to show it. Green on blue isn't very visible.

Edit: Another attempt with a lighter green:

Image
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Next

Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 1 guest