Page 1 of 2

[Done] more obvious icon for "Enabled"

PostPosted: Wed Apr 25, 2007 1:14 am
by Wladimir Palant
Bug 16891 complains that it is not obvious that you can disable filters by clicking in the "Enabled" column. A checkmark should be more obvious than a green dot. So I made a user style for this and would like to know what you think about it. Here is how it looks like:

Image

Re: Opinions requested: more obvious icon for "Enabled&

PostPosted: Wed Apr 25, 2007 1:20 am
by chewey
Neat. :-)

What about colour coding?
I'm unsure myself about that at the moment, but I think
making the checkmarks green may be a nice addition

PostPosted: Wed Apr 25, 2007 1:23 am
by Wladimir Palant
I have my doubts about that...

PostPosted: Wed Apr 25, 2007 1:31 am
by Josh
The checkmark looks good to me. How about using a red X of some kind for the disabled icon?

PostPosted: Wed Apr 25, 2007 1:35 am
by chewey
That could be misinterpreted as "this item is blocking".

PostPosted: Wed Apr 25, 2007 1:53 am
by Stupid Head
It might conflict with some themes. Here are some comments for a userstyle that does the opposite.

PostPosted: Wed Apr 25, 2007 2:21 am
by Wladimir Palant
The main problem with Stylish is that it doesn't have an icon for the "disabled" status - and recognizing a *missing* checkmark is hard.

If we look at themes with black background, maybe we should make the color of the checkmark somewhat greenish as chewey suggests. The correct solution would be to set a fixed background color for the tree but I am afraid people will not like it.

Re: Opinions requested: more obvious icon for "Enabled&

PostPosted: Wed Apr 25, 2007 4:28 am
by rick752
chewey wrote:I think making the checkmarks green may be a nice addition


I agree with chewey. The green makes it easier to spot a disabled filter when you are scanning the list.

PostPosted: Wed Apr 25, 2007 4:44 am
by rick752
Addition:
The inactive 'gray bars' themselves will not help much especially if you are using a Noia theme.

Image

I would definitely be looking for a color cue at this point.

PostPosted: Wed Apr 25, 2007 10:23 am
by Alan
I like the new version with the check mark just like it is. The meaning is now obvious, even to a colorblind person. I suspect that abandoning a color cue might make it more compatible with various themes too. Good work!

PostPosted: Wed Apr 25, 2007 11:27 pm
by Stupid Head
Alan wrote:The meaning is now obvious, even to a colorblind person. I suspect that abandoning a color cue might make it more compatible with various themes too.

That's assuming the background is light. If it is dark, then it'll be hard to see regardless of how good your vision is.

I like the checkmark, but I think it should be some color other than black.

PostPosted: Thu Apr 26, 2007 12:12 am
by Wladimir Palant
Ok, let's have green checkmarks for comparison:

Image

And the same thing with black background, just to see what it looks like:

Image

Anybody know themes with green background? :)

PostPosted: Thu Apr 26, 2007 1:32 am
by rick752
Even that small little bit of green just makes the eye see it a little better, imo. Even if you are color blind, it still should look slightly different I would think.
Anybody know themes with green background? :smile:

Irish Pimpzilla? :lol:

PostPosted: Thu Apr 26, 2007 1:48 am
by chewey
rick752 wrote:Even that small little bit of green just makes the eye see it a little better, imo. Even if you are color blind, it still should look slightly different I would think.

Yep, I agree.

PostPosted: Thu Apr 26, 2007 1:57 am
by Wladimir Palant
But the selected row is a problem now. I replaced the image in the post above to show it. Green on blue isn't very visible.

Edit: Another attempt with a lighter green:

Image