[Rejected] Future of "Collapse blocked elements" o
[Rejected] Future of "Collapse blocked elements" o
I recently (re-)discovered that "collapse blocked elements" is the default in Firefox 3. The browser will already do what Adblock Plus had to do "manually" so far, blocked elements will get the "display:none" style automatically. This means that I will be able to remove ugly and problematic code that does the collapsing in Adblock Plus right now. The new code won't work in Firefox 2 which means that I will do this change only once ~90% of the users switched to Firefox 3 (fortunately, AMO gives me that info now).
Now what should happen to the "collapse blocked elements" option? Browser's "display:none" can be overridden by the web page. So I see three alternatives right now:
1. "Collapse blocked elements" option stays and switches on "extra strong collapsing" - one that the web page cannot override. Disadvantages: flipping this option will not show any real effect, generally its usefulness will be very limited since websites have little reason to force blocked elements to occupy space.
2. Adblock Plus always makes sure that the web page cannot override "display:none" for blocked elements, without any options.
3. We just say that browser's default is good enough for us and Adblock Plus shouldn't do anything in addition.
Note that it won't be possible to target individual elements, so "only do the extra strong collapsing if the filter has a $collapse option" won't work.
I tend towards the third option since I don't see what a website would gain from overriding browser's default - other than preventing its layout from breaking, in which case we should let it override.
Opinions?
Now what should happen to the "collapse blocked elements" option? Browser's "display:none" can be overridden by the web page. So I see three alternatives right now:
1. "Collapse blocked elements" option stays and switches on "extra strong collapsing" - one that the web page cannot override. Disadvantages: flipping this option will not show any real effect, generally its usefulness will be very limited since websites have little reason to force blocked elements to occupy space.
2. Adblock Plus always makes sure that the web page cannot override "display:none" for blocked elements, without any options.
3. We just say that browser's default is good enough for us and Adblock Plus shouldn't do anything in addition.
Note that it won't be possible to target individual elements, so "only do the extra strong collapsing if the filter has a $collapse option" won't work.
I tend towards the third option since I don't see what a website would gain from overriding browser's default - other than preventing its layout from breaking, in which case we should let it override.
Opinions?
Last edited by Wladimir Palant on Fri Apr 24, 2009 8:10 pm, edited 1 time in total.
Re: Future of "Collapse blocked elements" option
Should this already work if I disable the option in FF 3.0b4 or is this a new function (trunk)?Wladimir Palant wrote:I recently (re-)discovered that "collapse blocked elements" is the default in Firefox 3. The browser will already do what Adblock Plus had to do "manually" so far, blocked elements will get the "display:none" style automatically.
Just want to be sure . So here are some quick examples where it doesn't work without the option (and won't break the layout if collapsed).
Example 1 - Shows a broken image where the counter was if you block .tophits4u.
Example 2 - Some ads covered in iframes leave white spaces without the option
Example 3 - Same here: Ads in iframes blocked, but the frames are not hidden
=> I don't like option 3.
Example 1 - Shows a broken image where the counter was if you block .tophits4u.
Example 2 - Some ads covered in iframes leave white spaces without the option
Example 3 - Same here: Ads in iframes blocked, but the frames are not hidden
=> I don't like option 3.
Ok, I guess I should have checked a little more. Apparently, the browser will only hide if the content policy claims to reject based on the server - and then only for some HTML tags (img, input, object, embed, applet).
I changed Adblock Plus to trigger this feature and uploaded a new development build to http://adblockplus.org/devbuilds/ - please check whether Option 3 is viable now. And I'll file a bug about frames not being collapsed.
I changed Adblock Plus to trigger this feature and uploaded a new development build to http://adblockplus.org/devbuilds/ - please check whether Option 3 is viable now. And I'll file a bug about frames not being collapsed.
Ok on Cybernet new the bottom sponsors on the right hand side doesn't collapse if I don't check that option.
Firefox: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032505 Minefield/3.0b5pre
ABP: ...2008032513 (I updated just before finding this to the latest dev build)
Firefox: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032505 Minefield/3.0b5pre
ABP: ...2008032513 (I updated just before finding this to the latest dev build)
So I will have to wait for the bug being fixed until I can change my mind.Wladimir Palant wrote:I changed Adblock Plus to trigger this feature and uploaded a new development build to http://adblockplus.org/devbuilds/ - please check whether Option 3 is viable now. And I'll file a bug about frames not being collapsed.