[Done] New Disabled Icon to match the new Enabled icon

Various discussions related to Adblock Plus development

Postby Wladimir Palant » Thu Nov 06, 2008 4:13 pm

fanboy, this looks good:
Image
So I think I will take this change. But it doesn't help with the checkboxes :)

Edit: http://hg.mozdev.org/adblockplus/rev/92769c3eb0c9
Last edited by Wladimir Palant on Thu Nov 06, 2008 5:53 pm, edited 1 time in total.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Dr. Evil » Thu Nov 06, 2008 5:25 pm

Maybe make the checkboxes a bit darker for the headings, too:
Image
Dr. Evil
 
Posts: 194
Joined: Fri Sep 08, 2006 3:51 pm

Postby Wladimir Palant » Thu Nov 06, 2008 5:53 pm

Dr.Evil, that makes the filters look disabled in comparison.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby fanboy » Thu Nov 06, 2008 11:12 pm

Wladimir Palant wrote:So I think I will take this change. But it doesn't help with the checkboxes :)


How about indent the filter checkbox's to the right? (keep them in the same row, just move them to right) or indent the subscription checkbox to the left?

or insert a small gap between filter and subscription?
User avatar
fanboy
 
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am

Postby Adblock Plus Fan » Thu Nov 06, 2008 11:30 pm

How about this?
Image
(Just posting this to potentially inspire some ideas)

I personally feel a little awkward with it since I'm not used to that order.
User avatar
Adblock Plus Fan
 
Posts: 1255
Joined: Sat Feb 24, 2007 12:08 pm

Postby fanboy » Thu Nov 06, 2008 11:38 pm

Wladimir Palant wrote:fanboy, there isn't much space on the left. Moving filter checkboxes to the right is what I tried - looks ugly and is still not quite obvious because of the gaps (subscription description and comments).
User avatar
fanboy
 
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am

Postby Adblock Plus Fan » Thu Nov 06, 2008 11:41 pm

Ah....Sorry fanboy, I missed it :P
User avatar
Adblock Plus Fan
 
Posts: 1255
Joined: Sat Feb 24, 2007 12:08 pm

Postby fanboy » Fri Nov 07, 2008 12:29 am

another suggestion, use a seperator? similar to ones use in the bookmarks.
User avatar
fanboy
 
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am

Postby Dr. Evil » Fri Nov 07, 2008 4:06 am

I think that comments should have a disabled checkbox.
I think the blank space always looks kind of weird, it's just worse for subscriptions because there are some comments in a row.

ImageImage vs. ImageImage
Dr. Evil
 
Posts: 194
Joined: Fri Sep 08, 2006 3:51 pm

Postby Wladimir Palant » Fri Nov 07, 2008 8:59 am

fanboy wrote:or insert a small gap between filter and subscription?

Why separate something that belongs together?

Adblock Plus Fan wrote:How about this?

You can reorder columns using Drag&Drop ;)
But that doesn't look nice either in the real extension because the "Enabled" column is wider than the checkbox (centering the checkbox isn't possible).

Dr. Evil wrote:I think that comments should have a disabled checkbox.

I doubt that. Why show a checkbox for something that cannot be enabled/disabled by definition?
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby pirlouy » Fri Nov 07, 2008 9:45 pm

A bit off-topic, but speaking about icons, I have to tell you that statusbar icon is unreadable. It's impossible to see 3 letters except if you are at 10cm of the screen. :/

For statusbar it should be an icon without letter, or just one letter.
User avatar
pirlouy
 
Posts: 332
Joined: Sat Jun 10, 2006 2:33 pm
Location: France

Postby Wladimir Palant » Sat Nov 08, 2008 10:51 am

pirlouy, yes - this is off-topic. Question: does it have to be readable? I think it should be recognizable, that's the important thing.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby pirlouy » Sat Nov 08, 2008 12:44 pm

So maybe you should think about removing these letters... But it's just a suggestion, maybe finding a new better icon without letters could be the right solution.

Sorry, I didn't want to create a thread for this.
User avatar
pirlouy
 
Posts: 332
Joined: Sat Jun 10, 2006 2:33 pm
Location: France

Previous

Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 11 guests