[Done] Visual indication for elements with disabled filters

Various discussions related to Adblock Plus development

[Done] Visual indication for elements with disabled filters

Postby cubefox » Wed Dec 03, 2008 9:07 pm

Since Adblock Plus 1.0 we are able to disable a filter in the "blockable items list" quickly by right clicking on the blocked item.
This is very useful if a site doesn't work with your filter list, you can disable actually used filters to see which filter interferes.

But if you disable a filter in the items list (and you find out that this filter is not interferingg) it could be VERY hard to find this element again to re-enable the filter by right clicking the element. This is beacause there is no visual indication ("state") for such elements. At present (if you not kept it in mind), you have to right click on each element and look if there is an entry called "Re-eneable filter x"...

Maybe the element with the disabled filter should be higlighted in a additional color (similar to the red blocked elements). Or maybe the filter in the filter collumn should not get hidden if this filter get disabled, but only viewed grayed out and a comment behind the filter like this: [filter disabled].

Anyway, a visual indication of elements with (recently?) disabled filters would be very helpful.
cubefox
 
Posts: 7
Joined: Wed Dec 03, 2008 7:50 pm
Location: Germany

Postby Wladimir Palant » Wed Dec 03, 2008 10:49 pm

Currently, testing whether the item matches a disabled filter isn't a very fast operation. Ok, this could be changed relatively easily (we would display a "random" matching filter instead of the shortest as it is now). However, when should the list check whether there is a matching disabled filter? I guess, when the item is added. Filters might change and this information will become outdated. Of course, the information for blocked items doesn't get updated either, so we could just ignore that problem...
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Wladimir Palant » Thu Dec 04, 2008 12:04 am

Done: http://hg.mozdev.org/adblockplus/rev/94029fbf379f

Will create a development build shortly.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

One wish or question...

Postby Stefan » Thu Dec 04, 2008 12:40 am

Removed: Please do not hijack forum threads, especially not in Future Development forum. Post your question in the General forum and you will get an answer.
Stefan
 

Postby cubefox » Thu Dec 04, 2008 6:32 pm

Thank you. :)
cubefox
 
Posts: 7
Joined: Wed Dec 03, 2008 7:50 pm
Location: Germany

Postby Adblock Plus Fan » Fri Dec 05, 2008 12:18 am

Now that sorting of the blockable items list is default sorted by state, would it make sense if items that matches a disabled filter gets its own State?
Image
In my screenshot example I imagine it gets its own icon and after a page reload, it should be placed just below the green whitelist entries.
Right now they just get mixed alphabetically into the unfiltered group.
User avatar
Adblock Plus Fan
 
Posts: 1255
Joined: Sat Feb 24, 2007 12:08 pm

Postby Wladimir Palant » Fri Dec 05, 2008 8:38 am

Yes, I thought about that as well, would make sense. I am only unsure about the icon.
Last edited by Wladimir Palant on Fri Dec 05, 2008 4:04 pm, edited 1 time in total.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Adblock Plus Fan » Fri Dec 05, 2008 10:28 am

Wladimir Palant wrote:I am only unsure about the icon.
If you choose to change it, I think it should somehow look related to the little grey dot. On the other hand, maybe it's more logical if they don't get a new icon...
Just let them have the same icon they have now, the same as unfiltered elements. It's enough if they are listed right below the green whitelists.
User avatar
Adblock Plus Fan
 
Posts: 1255
Joined: Sat Feb 24, 2007 12:08 pm

Postby Wladimir Palant » Fri Dec 05, 2008 4:05 pm

Having the same icon but different sorting isn't good - it makes sorting work in an unexpected way. Also, I think the items with disabled filters should go under the blocked items - they are basically the same as not matching any filter at all. Edit: Noticed that whitelisted items are actually shown under the blocked ones. My bad, we actually mean the same thing.

I moved the unrelated discussion to this thread: http://adblockplus.org/forum/viewtopic.php?t=3226
Last edited by Wladimir Palant on Fri Dec 05, 2008 4:38 pm, edited 1 time in total.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Wladimir Palant » Fri Dec 05, 2008 4:34 pm

Tried some image filters, here is what I got:

Image
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Wladimir Palant » Fri Dec 05, 2008 4:42 pm

Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re:

Postby smk » Sat Dec 06, 2008 3:25 pm

nice, always wanted this feature :)
smk
 
Posts: 100
Joined: Mon Jul 14, 2008 6:54 am

Postby MonztA » Mon Dec 08, 2008 6:28 pm

Is it possible to make this work also with element hiding filters?
MonztA
ABP IT Officer
 
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Postby Ares2 » Mon Dec 08, 2008 6:45 pm

Ares2
 
Posts: 1275
Joined: Fri Feb 15, 2008 1:47 pm

Postby MonztA » Mon Dec 08, 2008 7:10 pm

OK, thanks Ares.
MonztA
ABP IT Officer
 
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Next

Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 17 guests