[Done] Add "Filter source" column to blockable items

Various discussions related to Adblock Plus development

[Done] Add "Filter source" column to blockable items

Postby Hubird » Mon Jan 11, 2010 3:53 am

I was thinking it would be nice to be able to sort the filters in the blockable items list by weather they were in the My Rules sections or not.
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: Blockable items sort user filters

Postby Wladimir Palant » Mon Jan 11, 2010 10:41 am

In other words - add "Filter source" as an additional column. Only problem: there can be more than one. Probably show all of them separated by commas? And the tooltip would show it properly if necessary.

Edit: Added to roadmap (unscheduled)
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Blockable items sort user filters

Postby Hubird » Mon Jan 11, 2010 10:50 am

Wladimir Palant wrote:In other words - add "Filter source" as an additional column.

Yes

Wladimir Palant wrote:Only problem: there can be more than one. Probably show all of them separated by commas?

I would have been happy just to have "Filter source" as an additional column, but if you want to take it further the that's great :)
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: Add "Filter source" column to blockable items

Postby Wladimir Palant » Mon Jan 11, 2010 11:03 am

Renamed and moved to future development forum.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Roadmap] Add "Filter source" column to blockable items

Postby Wladimir Palant » Thu Sep 30, 2010 9:07 am

Scheduled for Adblock Plus 1.4, tentatively.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Roadmap] Add "Filter source" column to blockable items

Postby Hubird » Thu Apr 28, 2011 3:38 am

Please see viewtopic.php?f=1&t=7483 for a working example build and code changes used.
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: [Roadmap] Add "Filter source" column to blockable items

Postby Wladimir Palant » Thu Apr 28, 2011 9:28 am

Thanks a lot! Pushed: https://hg.adblockplus.org/adblockplus/rev/d8618d5dcd31 (minus en-GB translation, I prefer to leave that to the translator)
Also a few minor corrections: https://hg.adblockplus.org/adblockplus/rev/162cf2a2a2fe

Style-wise you have to know that Adblock Plus mixes two bracket styles - old code uses brackets on the same line (per Mozilla's coding guidelines), in the newer code I gave up on this and use the IMHO more logical "brackets on a separate line". I didn't reformat all the old code but I do it every time I change it. Same goes for variable declarations - old code still uses "var foo" while newer code uses "let foo" exclusively (the latter is safer because block-scoped, the scope of the former declaration is non-obvious and can lead to mistakes). Finally - no tab characters, indentation by two spaces.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Done] Add "Filter source" column to blockable items

Postby Gingerbread Man » Thu Apr 28, 2011 10:26 am

Thank you! I was looking forward to this.
Gingerbread Man
 

Re: [Done] Add "Filter source" column to blockable items

Postby Hubird » Sun May 01, 2011 1:39 pm

Just noticed the new "Filter source" column lists hiding rules in disabled subscriptions. Do you think this is an issue ?
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: [Done] Add "Filter source" column to blockable items

Postby Wladimir Palant » Sun May 01, 2011 2:24 pm

The tooltip does the same - it is impossible to tell whether the subscription was already disabled when the document loaded so all subscriptions are listed where the rule is found.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Done] Add "Filter source" column to blockable items

Postby Gingerbread Man » Fri Aug 12, 2011 5:32 pm

What happened to this feature? I could've sworn I've seen it in a release version of Adblock Plus, but now it's gone.

Adblock Plus 1.3.9
Aurora 2011-08-12
User avatar
Gingerbread Man
 
Posts: 1339
Joined: Fri Aug 12, 2011 5:28 am

Re: [Done] Add "Filter source" column to blockable items

Postby Wladimir Palant » Fri Aug 12, 2011 6:01 pm

It is in the development builds: https://adblockplus.org/en/development-builds
Didn't make it into a release build yet because this requires string changes.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Done] Add "Filter source" column to blockable items

Postby Gingerbread Man » Fri Aug 12, 2011 7:30 pm

I suppose in the grand scheme of Adblock Plus development, 3 and ½ months isn't much, and I come off as impatient. It's back to the development build for me. Thank you.
User avatar
Gingerbread Man
 
Posts: 1339
Joined: Fri Aug 12, 2011 5:28 am


Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 3 guests