Open filter composer for "edit filter in effect"

Various discussions related to Adblock Plus development

Open filter composer for "edit filter in effect"

Postby ads are unhealthy » Wed Feb 24, 2010 9:07 pm

For element hiding rules I would prefer "edit filter in effect" in the right-click menu of "(open) blockable items [on current page]" to respawn the editor that was used to initially create it. Currently that edit opens "adblock plus preferences" and only allows one to tinker with the per se text of the filter.

This would have allowed me to widen or narrow this filter visually

Code: Select all
mail.yahoo.com##*[id^="scAdContainer"]
ads are unhealthy
 
Posts: 3
Joined: Wed Feb 24, 2010 8:14 pm

Re: [req] edit filter in effect... respawn Compose element rule

Postby Wladimir Palant » Wed Feb 24, 2010 10:24 pm

I don't think this is possible - the composer for element hiding rules needs an element to work on but this element isn't known. Adblock Plus only knows that an element hiding rule was applied in a document but it doesn't know which element it was applied to.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [req] edit filter in effect... respawn Compose element rule

Postby Dr. Evil » Wed Feb 24, 2010 11:26 pm

Can't you get this element with document.querySelectorAll?
Dr. Evil
 
Posts: 194
Joined: Fri Sep 08, 2006 3:51 pm

Re: [req] edit filter in effect... respawn Compose element rule

Postby Wladimir Palant » Thu Feb 25, 2010 10:28 am

Ah, right - in Firefox 3.5 this is possible.

So this leaves us with the (rather common) scenario where the filter belongs to a filter subscription - you probably don't really want to edit it then but disable (and probably also look at the subscription it belongs to). And with the scenario where you want to delete the filter instead of changing it (this can be solved by having "Delete this filter rule" and "Update this filter rule" buttons in the dialog instead of "Add filter rule").

It also doesn't make much sense to have this for element hiding rules only - the first candidate would be the "usual" filter composer which is actually part of Adblock Plus rather than Element Hiding Helper.

Let's consider this (=> Future Development)
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany


Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 4 guests