[Done] EHH: Don't include tag name by default

Various discussions related to Adblock Plus development

[Done] EHH: Don't include tag name by default

Postby Hubird » Thu Apr 22, 2010 4:22 pm

Whenever possible the filter list maintainers don't include the DIV tag for hiding rules, could you modify the "Element Hiding Helper" so that is is not selected by default.
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: EHH: DIV

Postby Michael » Thu Apr 22, 2010 5:50 pm

I agree with a Hubird; smart and automatic detection of whether or not the tag name is required would be really useful in the Adblock Plus Element Hiding Helper.
Michael
 
Posts: 1361
Joined: Sat Dec 19, 2009 1:29 pm

Re: EHH: DIV

Postby Dr. Evil » Fri Apr 23, 2010 6:46 pm

Indeed. I think it should only be selected as a default when there's no class or id.
Dr. Evil
 
Posts: 194
Joined: Fri Sep 08, 2006 3:51 pm

Re: EHH: Don't include tag name by default

Postby Wladimir Palant » Sat Apr 24, 2010 4:17 pm

I agree, tag name shouldn't be selected by default if class or id are present - over to "Future development".
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Done] EHH: Don't include tag name by default

Postby Wladimir Palant » Tue Oct 26, 2010 11:35 am

This has been done a few days ago: https://hg.adblockplus.org/elemhidehelp ... 265699b8ae
The current development build already has this change.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany


Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 5 guests