[Done] Create domain exceptions for rules in subscriptions

Various discussions related to Adblock Plus development

[Done] Create domain exceptions for rules in subscriptions

Postby Hubird » Sun May 23, 2010 4:02 pm

How about adding the ability to disable a hiding rule only for a specific page to the blockable items list context menu (like we can for blocking rules). We don't need to add any more entries to the context menu the existing "Add exception rule for item" can be used.

For example if we had the filter

Code: Select all
###biguglyadbox

And a user discovered it was causing problems on example.com he or she could simply right click on it in the blockable items list and choose "Add exception rule for item" which would then create a new rule

Code: Select all
~example.com###biguglyadbox


Also I thought about putting these sorts of rules under the "My exceptions rules" section but I guess since they are not strictly exception rules they should stay in the "My Element Hiding rules" section.
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: [Suggestion] Quickly create hiding rule with exception

Postby Wladimir Palant » Wed May 26, 2010 7:48 am

I thought we had this feature for a while now? Just tried it with an element hiding rule - "Disable this filter on example.com" context menu item is enabled and seems to adjust the filter correctly. This won't work for filters in filter subscriptions of course - no way to change those. Is that your problem or is there another scenario where this doesn't work?
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Suggestion] Quickly create hiding rule with exception

Postby Hubird » Wed May 26, 2010 8:25 am

I would like the user to be able to quickly and easily create an exception rule for an element hide from the context menu (at the moment all we can do it disable the rule all together).

Image
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: [Suggestion] Quickly create hiding rule with exception

Postby Wladimir Palant » Wed May 26, 2010 8:29 am

Hubird, this must be a filter from a filter subscription - normally you would also have "Disable this filter on au.yahoo.com" in the menu.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Suggestion] Quickly create hiding rule with exception

Postby Hubird » Wed May 26, 2010 8:31 am

Wladimir Palant wrote:Hubird, this must be a filter from a filter subscription - normally you would also have "Disable this filter on au.yahoo.com" in the menu.


That's correct. The screen shot is a mock up of what I am suggesting. Disabling a generic hide is not always the best solution for a user. I'm after a quick and easy way to create a hiding rule with a domain exception.
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: [Suggestion] Quickly create hiding rule with exception

Postby Hubird » Sun Jun 06, 2010 10:03 am

Any thoughts on this, did I not make myself clear ?
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: [Suggestion] Quickly create hiding rule with exception

Postby Wladimir Palant » Sun Jun 06, 2010 4:42 pm

I think I understood what you mean - you want the ability to create a rule that will work as a "modifier" for an existing element hiding rule (which might not be editable itself because in a filter subscription). While the functionality is clearly desirable, I don't think that this is the right way - having one rule influence another in this way will be problematic both for the software and the user. Some way to disable/re-enable rules on domains without having to modify the filter text would be a nice feature however. The plan goes like this:

1) "Disable filter on ..." context menu entry is available for all filters, including the ones from filter subscriptions. This means both blocking and element hiding rules.
2) When the user uses this context menu entry the filter stays unchanged, a modifier like "~example.com" is stored for it however. This modifier survives filter subscription updates just like the "disabled" flag does.
3) When a filter is displayed (in Blockable Items or Preferences) its "full" form is used, meaning that existing modifiers are added to the filter text. Context menu entries like "Re-enable filter on ..." allow removing modifiers.

Moving to "Future development" to get some comments on that proposal.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Create domain exceptions for rules in subscriptions

Postby Michael » Sun Jun 06, 2010 9:43 pm

I would suggest that when Disable filter on ... is selected for subscription filters the rule should be automatically disabled and an identical filter with the exception appended should be created in the relevant personal filters section; this solution would reduce the additional development time required would make the changes clearer to the user.
Michael
 
Posts: 1361
Joined: Sat Dec 19, 2009 1:29 pm

Re: Create domain exceptions for rules in subscriptions

Postby Wladimir Palant » Mon Jun 07, 2010 8:37 am

The problem with that suggestion: if the filter subscription changes that filter (probably to address the very same issue) the user suddenly gets two filters, both enabled.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Create domain exceptions for rules in subscriptions

Postby Hubird » Sun Aug 15, 2010 4:53 am

Wladimir Palant wrote:The problem with that suggestion: if the filter subscription changes that filter (probably to address the very same issue) the user suddenly gets two filters, both enabled.


If a hiding filter with a domain exception supersedes standard hiding filters (both general and for specific domain ones) then I feel having two is not a major issue (it is ultimately up to the end user to make to worry about duplicate rules of any type). The ability to create an exception rule from the context menu would also benefit those users who like to see certain ads for whatever reason (Google adsense comes to mind).
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: Create domain exceptions for rules in subscriptions

Postby Wladimir Palant » Sat Jun 23, 2012 8:34 am

I rather propose this syntax:

Code: Select all
foo.example.com#@#biguglyadbox


This should disable the rule "##biguglybox" or "example.com##biguglybox" on foo.example.com. That's an exception rule, if it applies then the regular element hiding rule doesn't.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Create domain exceptions for rules in subscriptions

Postby Wladimir Palant » Sat Jun 23, 2012 2:50 pm

Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Done] Create domain exceptions for rules in subscriptions

Postby Hubird » Sat Jun 23, 2012 3:28 pm

That was quick from proposed syntax to done :D

I guess the existing domain exception syntax will remain?
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: [Done] Create domain exceptions for rules in subscriptions

Postby knight00931 » Sat Jun 23, 2012 4:04 pm

Excuse me, will this syntax make problems on older version?
knight00931
 
Posts: 62
Joined: Fri Aug 27, 2010 5:53 am
Location: Taiwan

Re: [Done] Create domain exceptions for rules in subscriptions

Postby Wladimir Palant » Sat Jun 23, 2012 5:14 pm

No, Adblock Plus 2.0 and below will treat these rules as blocking rules (they don't meet the requirements for "simplified" element hiding syntax) - ones that can never block anything.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Next

Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 1 guest