ABP does not unhide nodes no longer matching :-abp-has(...)

Various discussions related to Adblock Plus development

ABP does not unhide nodes no longer matching :-abp-has(...)

Postby krystian3w » Sun Dec 16, 2018 7:35 pm

Test links
Code: Select all
https://www.e-forma.pl/3575,7nutrition-citrulline-malate-b6-250g-cytrulina.html
Code: Select all
http://homeoapteka.pl/2822,bonimed-ziolowy-balsam-kregowy-ojca-grzegorza-100-g.html


Problem:
How can I block only newsletter pop-up when filter:

Code: Select all
e-forma.pl,homeoapteka.pl#?##colorbox:-abp-has(#newsletter_colorbox)


breaks too gallery and I cannot see bigger photos products (magnifier/loupe plugin on site is should not enough for all)?

Overlay/background I can detect by style tag and cut only for newsletter:

Code: Select all
e-forma.pl,homeoapteka.pl###cboxOverlay:not([style="opacity: 0.9; visibility: visible; display: block; cursor: pointer;"])


Helpful graphics:
Image Image


Similar bug fixed in uBlock Origin: https://github.com/uBlockOrigin/uBlock- ... issues/341
Last edited by krystian3w on Sun Dec 16, 2018 8:46 pm, edited 2 times in total.
User avatar
krystian3w
 
Posts: 2
Joined: Sun Dec 16, 2018 7:08 pm

Re: ABP does not unhide nodes no longer matching :-abp-has(...)

Postby mapx » Sun Dec 16, 2018 8:02 pm

You could open an issue on the bug tracker
https://issues.adblockplus.org
User avatar
mapx
 
Posts: 21947
Joined: Thu Jan 06, 2011 3:01 pm

Re: ABP does not unhide nodes no longer matching :-abp-has(...)

Postby mapx » Sun Dec 16, 2018 8:20 pm

defect type if I understand correctly ..
User avatar
mapx
 
Posts: 21947
Joined: Thu Jan 06, 2011 3:01 pm

Re: ABP does not unhide nodes no longer matching :-abp-has(...)

Postby krystian3w » Sun Dec 16, 2018 8:28 pm

Yes, this is should defect.

https://issues.adblockplus.org/ticket/7170#ticket - I send.

I hope that the ticked will be moved / modified without closing as there is no duplicate.

...


I found workaround with this background detection:
Code: Select all
e-forma.pl,homeoapteka.pl###cboxOverlay:not([style="opacity: 0.9; visibility: visible; display: block; cursor: pointer;"])
e-forma.pl,homeoapteka.pl###cboxOverlay:not([style="opacity: 0.9; visibility: visible; display: block; cursor: pointer;"]) ~ #colorbox

but can cut still to many pop-up as only newsletter.
It's enough for the background code to not be above pop-up code in the dom html tree, and it will not be the handle of this bypass anymore.
In addition, closing once a pop-up also causes the workaround to not work.

Another problematic domains:

Code: Select all
oponyalbert.pl
meblezagrosze.pl
annalotan.pl
User avatar
krystian3w
 
Posts: 2
Joined: Sun Dec 16, 2018 7:08 pm


Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 1 guest