[Done] Don't use italics for disabled rules
Re: remove "italic" from disabled rules
I support that as well
Re: [FEATURE REQUEST] remove "italic" from disabled rules
As I already said in your other topic:
How do you suggest a disabled rule should be indicated? Please consider that it needs to be obvious at one glance that it is disabled. Meaning that the checkbox isn't sufficient (looking over to it is no longer "at one glance", people also might forget to do it). Also, the gray text color is already used by comments so that there isn't enough distinction.
How do you suggest a disabled rule should be indicated? Please consider that it needs to be obvious at one glance that it is disabled. Meaning that the checkbox isn't sufficient (looking over to it is no longer "at one glance", people also might forget to do it). Also, the gray text color is already used by comments so that there isn't enough distinction.
Re: [FEATURE REQUEST] remove "italic" from disabled rules
use color RED for disabled rules.
Re: [FEATURE REQUEST] remove "italic" from disabled rules
Or just greyed out (like it is currently), but without the italics.
Re: [FEATURE REQUEST] remove "italic" from disabled rules
Why the opposition to italics?
Re: [FEATURE REQUEST] remove "italic" from disabled rules
Red color is already used to indicate invalid rules (which makes more sense I think).
Re: [FEATURE REQUEST] remove "italic" from disabled rules
italics is SUX and unreadable
-
- Posts: 5
- Joined: Mon Dec 19, 2011 5:05 am
Re: [FEATURE REQUEST] remove "italic" from disabled rules
The addon should provide an interface to customise the applicable colours and styles.
That should apply to all addons in general.
That should apply to all addons in general.
Re: [FEATURE REQUEST] remove "italic" from disabled rules
@aAVvLSkwhzhQylRc: There is one already - it is called "themes". It allows you to change the look&feel of the browser and most add-ons, including Adblock Plus.</sarcasm>
-
- Posts: 8
- Joined: Wed Jan 11, 2012 1:14 am
Re: [FEATURE REQUEST] remove "italic" from disabled rules
How about moving the "Enabled" checkbox to the left of the pattern instead of the right? Patterns have a variable and potentially very long length, and thus the pattern field has quite a bit of width, which as you pointed out makes the Enabled checkbox not as obvious. If you put the Enabled checkbox to the left of the pattern, it would become immediately obvious.
The normal styling for HTML checkbox controls follows the same design (checkbox on the left, text on the right) for the same reason: allow aligning the checkboxes without dissociating them from the text.
I've tried this locally, and it looks much better. I think it would work better as a default.
The normal styling for HTML checkbox controls follows the same design (checkbox on the left, text on the right) for the same reason: allow aligning the checkboxes without dissociating them from the text.
I've tried this locally, and it looks much better. I think it would work better as a default.
Re: [FEATURE REQUEST] remove "italic" from disabled rules
@Josh : Could you post screenshots of your new UI so we could see ?
Re: [FEATURE REQUEST] remove "italic" from disabled rules
@JoshTriplett: Columns can be reordered by drag&drop, anybody can do that if they like. Originally, having Enabled on the left was ugly because we had a hierarchical list. Now we could theoretically move it to the left by default, for me that looks rather odd however (I had it on the right for the past five years).
@vinny86: Simply drag the column header with the mouse.
@vinny86: Simply drag the column header with the mouse.
-
- Posts: 8
- Joined: Wed Jan 11, 2012 1:14 am
Re: [FEATURE REQUEST] remove "italic" from disabled rules
It did take a moment to get used to, but I think the result works much better now that the hierarchy has gone away.Wladimir Palant wrote:@JoshTriplett: Columns can be reordered by drag&drop, anybody can do that if they like. Originally, having Enabled on the left was ugly because we had a hierarchical list. Now we could theoretically move it to the left by default, for me that looks rather odd however (I had it on the right for the past five years).
Re: [FEATURE REQUEST] remove "italic" from disabled rules
Moved to "Future development", I think that we are going to do it like this. Now we only need a sensible approach for subscriptions ("enabled" needs to move to the left there as well).