[Done] Don't use italics for disabled rules

Various discussions related to Adblock Plus development

[Done] Don't use italics for disabled rules

Postby TNTC4 » Sat Dec 17, 2011 10:41 pm

please Wladimir, remove "italic" from disabled rules.
It's unreadable.
just change color or anything else but remove the "italic".
Image
User avatar
TNTC4
 
Posts: 16
Joined: Mon Mar 28, 2011 9:43 am

Re: remove "italic" from disabled rules

Postby vinny86 » Tue Dec 20, 2011 3:49 am

I support that as well :)
User avatar
vinny86
 
Posts: 735
Joined: Thu Sep 16, 2010 6:17 pm

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby Wladimir Palant » Thu Dec 22, 2011 11:55 am

As I already said in your other topic:

How do you suggest a disabled rule should be indicated? Please consider that it needs to be obvious at one glance that it is disabled. Meaning that the checkbox isn't sufficient (looking over to it is no longer "at one glance", people also might forget to do it). Also, the gray text color is already used by comments so that there isn't enough distinction.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby TNTC4 » Fri Dec 23, 2011 12:28 am

use color RED for disabled rules.
User avatar
TNTC4
 
Posts: 16
Joined: Mon Mar 28, 2011 9:43 am

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby fanboy » Fri Dec 23, 2011 12:32 am

Or just greyed out (like it is currently), but without the italics.
User avatar
fanboy
 
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby PTS » Fri Dec 23, 2011 1:18 am

Why the opposition to italics?
PTS
 
Posts: 3
Joined: Fri Apr 30, 2010 10:47 pm

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby Wladimir Palant » Fri Dec 23, 2011 6:04 pm

Red color is already used to indicate invalid rules (which makes more sense I think).
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby TNTC4 » Sat Dec 24, 2011 6:10 pm

italics is SUX and unreadable
User avatar
TNTC4
 
Posts: 16
Joined: Mon Mar 28, 2011 9:43 am

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby aAVvLSkwhzhQylRc » Sun Dec 25, 2011 1:05 pm

The addon should provide an interface to customise the applicable colours and styles.
That should apply to all addons in general.
aAVvLSkwhzhQylRc
 
Posts: 5
Joined: Mon Dec 19, 2011 6:05 am

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby Wladimir Palant » Mon Jan 02, 2012 4:19 pm

@aAVvLSkwhzhQylRc: There is one already - it is called "themes". It allows you to change the look&feel of the browser and most add-ons, including Adblock Plus.</sarcasm>
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby JoshTriplett » Wed Jan 11, 2012 3:37 am

How about moving the "Enabled" checkbox to the left of the pattern instead of the right? Patterns have a variable and potentially very long length, and thus the pattern field has quite a bit of width, which as you pointed out makes the Enabled checkbox not as obvious. If you put the Enabled checkbox to the left of the pattern, it would become immediately obvious.

The normal styling for HTML checkbox controls follows the same design (checkbox on the left, text on the right) for the same reason: allow aligning the checkboxes without dissociating them from the text.

I've tried this locally, and it looks much better. I think it would work better as a default.
JoshTriplett
 
Posts: 8
Joined: Wed Jan 11, 2012 2:14 am

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby vinny86 » Wed Jan 11, 2012 4:11 am

@Josh : Could you post screenshots of your new UI so we could see ? :)
User avatar
vinny86
 
Posts: 735
Joined: Thu Sep 16, 2010 6:17 pm

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby Wladimir Palant » Wed Jan 11, 2012 8:37 am

@JoshTriplett: Columns can be reordered by drag&drop, anybody can do that if they like. Originally, having Enabled on the left was ugly because we had a hierarchical list. Now we could theoretically move it to the left by default, for me that looks rather odd however (I had it on the right for the past five years).

@vinny86: Simply drag the column header with the mouse.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby JoshTriplett » Sat Jan 28, 2012 5:48 am

Wladimir Palant wrote:@JoshTriplett: Columns can be reordered by drag&drop, anybody can do that if they like. Originally, having Enabled on the left was ugly because we had a hierarchical list. Now we could theoretically move it to the left by default, for me that looks rather odd however (I had it on the right for the past five years).


It did take a moment to get used to, but I think the result works much better now that the hierarchy has gone away.
JoshTriplett
 
Posts: 8
Joined: Wed Jan 11, 2012 2:14 am

Re: [FEATURE REQUEST] remove "italic" from disabled rules

Postby Wladimir Palant » Tue Jan 31, 2012 3:37 pm

Moved to "Future development", I think that we are going to do it like this. Now we only need a sensible approach for subscriptions ("enabled" needs to move to the left there as well).
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Next

Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 3 guests