[Rejected] Future of "Collapse blocked elements" o

Various discussions related to Adblock Plus development

[Rejected] Future of "Collapse blocked elements" o

Postby Wladimir Palant » Tue Mar 25, 2008 12:17 pm

I recently (re-)discovered that "collapse blocked elements" is the default in Firefox 3. The browser will already do what Adblock Plus had to do "manually" so far, blocked elements will get the "display:none" style automatically. This means that I will be able to remove ugly and problematic code that does the collapsing in Adblock Plus right now. The new code won't work in Firefox 2 which means that I will do this change only once ~90% of the users switched to Firefox 3 (fortunately, AMO gives me that info now).

Now what should happen to the "collapse blocked elements" option? Browser's "display:none" can be overridden by the web page. So I see three alternatives right now:

1. "Collapse blocked elements" option stays and switches on "extra strong collapsing" - one that the web page cannot override. Disadvantages: flipping this option will not show any real effect, generally its usefulness will be very limited since websites have little reason to force blocked elements to occupy space.

2. Adblock Plus always makes sure that the web page cannot override "display:none" for blocked elements, without any options.

3. We just say that browser's default is good enough for us and Adblock Plus shouldn't do anything in addition.

Note that it won't be possible to target individual elements, so "only do the extra strong collapsing if the filter has a $collapse option" won't work.

I tend towards the third option since I don't see what a website would gain from overriding browser's default - other than preventing its layout from breaking, in which case we should let it override.

Opinions?
Last edited by Wladimir Palant on Fri Apr 24, 2009 8:10 pm, edited 1 time in total.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Future of "Collapse blocked elements" option

Postby Ares2 » Tue Mar 25, 2008 12:53 pm

Wladimir Palant wrote:I recently (re-)discovered that "collapse blocked elements" is the default in Firefox 3. The browser will already do what Adblock Plus had to do "manually" so far, blocked elements will get the "display:none" style automatically.


Should this already work if I disable the option in FF 3.0b4 or is this a new function (trunk)?
Ares2
 
Posts: 1275
Joined: Fri Feb 15, 2008 1:47 pm

Postby Wladimir Palant » Tue Mar 25, 2008 12:56 pm

No, not a new function at all - introduced two years ago. So if you disable "Collapse blocked items" in any Firefox 3 beta you should already see this feature at work.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Ares2 » Tue Mar 25, 2008 1:10 pm

Just want to be sure :wink: . So here are some quick examples where it doesn't work without the option (and won't break the layout if collapsed).

Example 1 - Shows a broken image where the counter was if you block .tophits4u.

Example 2 - Some ads covered in iframes leave white spaces without the option

Example 3 - Same here: Ads in iframes blocked, but the frames are not hidden

=> I don't like option 3. :roll:
Ares2
 
Posts: 1275
Joined: Fri Feb 15, 2008 1:47 pm

Postby Wladimir Palant » Tue Mar 25, 2008 2:14 pm

Ok, I guess I should have checked a little more. Apparently, the browser will only hide if the content policy claims to reject based on the server - and then only for some HTML tags (img, input, object, embed, applet).

I changed Adblock Plus to trigger this feature and uploaded a new development build to http://adblockplus.org/devbuilds/ - please check whether Option 3 is viable now. And I'll file a bug about frames not being collapsed.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby IceDogg » Tue Mar 25, 2008 6:20 pm

Ok on Cybernet new the bottom sponsors on the right hand side doesn't collapse if I don't check that option.

Firefox: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032505 Minefield/3.0b5pre

ABP: ...2008032513 (I updated just before finding this to the latest dev build)
IceDogg
 
Posts: 909
Joined: Fri Jun 09, 2006 11:22 pm

Postby Wladimir Palant » Tue Mar 25, 2008 6:31 pm

Yes, that's because it is a frame - I already filed bug 424970 on that.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby IceDogg » Tue Mar 25, 2008 7:15 pm

Ok, I read over it again and I misunderstood what you had said before. My mistake. Thanks for your reply and not pointing out my oversight. :)
IceDogg
 
Posts: 909
Joined: Fri Jun 09, 2006 11:22 pm

Postby Ares2 » Tue Mar 25, 2008 8:19 pm

Wladimir Palant wrote:I changed Adblock Plus to trigger this feature and uploaded a new development build to http://adblockplus.org/devbuilds/ - please check whether Option 3 is viable now. And I'll file a bug about frames not being collapsed.


So I will have to wait for the bug being fixed until I can change my mind. :)
Ares2
 
Posts: 1275
Joined: Fri Feb 15, 2008 1:47 pm

Postby shareasus » Fri Feb 06, 2009 10:40 am

Is there any "collapse blocked elements" default in Firefox 3? Think not.
shareasus
 
Posts: 1
Joined: Fri Feb 06, 2009 10:38 am

Postby Wladimir Palant » Fri Feb 06, 2009 10:48 am

There is - Firefox 3 will collapse the elements even if Adblock Plus doesn't do it ("collapse blocked elements" is off). This doesn't work for frames however.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Wladimir Palant » Fri Apr 24, 2009 8:09 pm

My impression in the end - the change in Firefox is meant to solve a different problem and isn't a good match for Adblock Plus. So "Collapse blocked elements" should stay for now.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany


Return to Adblock Plus development

Who is online

Users browsing this forum: anconaek874 and 4 guests