[Done] New Disabled Icon to match the new Enabled icon

Various discussions related to Adblock Plus development

Postby fanboy » Sun Nov 02, 2008 11:25 am

Adblock Plus Fan wrote:I wouldn't mind exactly how this one looks, but wouldn't this put us at the mercy of how good the user's firefox theme is?


Exactly, makes ADP conform to the look, look more "native" to the end user. Using what ever theme is available isnt a bad idea, considering most other extension developers take advantage of it. :)
User avatar
fanboy
 
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am

Postby fanboy » Sun Nov 02, 2008 11:54 am

really its only a native box for the subscriptions, cant have thousands on native boxes for the filters?...would that be slower?

anyways, I was thinking something like this.. (mix of both the current and new)

Image
User avatar
fanboy
 
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am

Postby Wladimir Palant » Sun Nov 02, 2008 12:47 pm

Native checkboxes cannot be done - simply because XUL tree widget doesn't support them. However, the checkboxes on Fanboy's mockup look generic enough so that we can use them (as images). Unless there are some objections, that's what I will do.

Other question - do we want to differentiate checkboxes for subscriptions and checkboxes for filters? A while ago the checkboxes for filters were slightly indented to the right. Maybe we want this back?
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Gnintendo » Sun Nov 02, 2008 2:05 pm

I can make the X smaller easily (I will later,) but the other icon you suggested is too big and complex to conform with the design of the Tick mark as perfectly.

If you still want me to make something else I will, I'm just pointing that out.

I'll post a smaller version of the X as soon as I get it done.
Gnintendo
 
Posts: 5
Joined: Sat Jul 26, 2008 10:40 pm

Postby IceDogg » Sun Nov 02, 2008 3:47 pm

rick752 wrote:Hi Dogg. It's been a while, buddie. :)

Thanks, yea I've not been online as much last few weeks. I should be back on more now. Sometimes life gets in the way (don't ya just hate that). lol

On Topic: I think Fanboy's will work fine as well. What about making the empty box more bold so it will stand out more for a disabled filter(set)? Just a thought.
IceDogg
 
Posts: 909
Joined: Fri Jun 09, 2006 11:22 pm

Postby Wladimir Palant » Sun Nov 02, 2008 3:52 pm

Here is what I got now:
Image

Edit: Cleaned up the images and tweaked transparency.
Edit2: Pushed: http://hg.mozdev.org/adblockplus/rev/7e35431c435c
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Wladimir Palant » Sun Nov 02, 2008 4:39 pm

Wladimir Palant wrote:Other question - do we want to differentiate checkboxes for subscriptions and checkboxes for filters? A while ago the checkboxes for filters were slightly indented to the right. Maybe we want this back?

Tried this - looks ugly.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Gnintendo » Sun Nov 02, 2008 8:14 pm

OK, good, my main point was if you're going to change one of the icons, you need to change the other to match, and currently, that's the case.
Gnintendo
 
Posts: 5
Joined: Sat Jul 26, 2008 10:40 pm

Postby Hubird » Mon Nov 03, 2008 6:33 am

http://adblockplus.org/forum/viewtopic.php?t=2654

Wladimir Palant wrote:Text removed - please stay on-topic
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Postby Wladimir Palant » Mon Nov 03, 2008 9:20 am

Hubird: How about we keep each discussion in one topic? Ideally, we would also discuss one suggestion per topic. I already explained why implementing this feature isn't quite straightforward.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Hubird » Thu Nov 06, 2008 8:35 am

Other question - do we want to differentiate checkboxes for subscriptions and checkboxes for filters? A while ago the checkboxes for filters were slightly indented to the right. Maybe we want this back?


I know you decided against having them "slightly indented" but I think some way to "differentiate checkboxes for subscriptions and checkboxes for filters" is an excellent idea. It makes it easier to glace and the window and know exactly what is going on.

With subscriptions you have a bit of a gap between the main tick box and the filter tick boxes because of the subscription update details but the user created filters don't have this and it makes it even harder to tell them apart.
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Postby Wladimir Palant » Thu Nov 06, 2008 12:09 pm

Yes, and it is that gap (and comments) that makes indented checkboxes look ugly. Any suggestions on how to differentiate better? I would like to prevent using different images for filters but it can be done if it makes sense.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby fanboy » Thu Nov 06, 2008 1:50 pm

how about move the subscription ticks to the left, and keep the filter ticks to the right?
User avatar
fanboy
 
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am

Postby Wladimir Palant » Thu Nov 06, 2008 2:04 pm

fanboy, there isn't much space on the left. Moving filter checkboxes to the right is what I tried - looks ugly and is still not quite obvious because of the gaps (subscription description and comments).
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby fanboy » Thu Nov 06, 2008 2:43 pm

how about make subscription headings in bold?
User avatar
fanboy
 
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am

PreviousNext

Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 6 guests