[Done] Blockable items column indicating element domain

Various discussions related to Adblock Plus development

[Done] Blockable items column indicating element domain

Postby Adblock Plus Fan » Tue Dec 30, 2008 6:10 pm

Adblock Plus Fan wrote:2. The Filter column very faintly hints that the yieldmanager script is not loaded from mediafire.com, but it is loaded from a frame.

@Wladimir
do you think this issue is worth making a new column in the blockable items list?
I was thinking about an extra column that tells us which domain the item is loaded from. I think this might help to get better overview now that we got domain specific filters.

(And maybe we could have a context menu option to copy the domain? Or maybe that's useless...)


edited:
User avatar
Adblock Plus Fan
 
Posts: 1255
Joined: Sat Feb 24, 2007 12:08 pm

Postby Wladimir Palant » Tue Jan 06, 2009 10:00 am

Sounds like something that would make sense. Column should be hidden by default but the info should always be visible in the tooltip. What could this column be called? "Document source"?
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Adblock Plus Fan » Wed Jan 07, 2009 4:50 am

Wladimir Palant wrote:Column should be hidden by default but the info should always be visible in the tooltip.
That's a great idea.

Wladimir Palant wrote:"Document source"?
I'm fine with this.
Alternatively, "originating domain"?
If it has something with "domain" in it, it might be easier for people to connect this feature with the Domain restriction feature.



Looking back in hindsight, the decision to change the Blockable list from vertical sidebar to horizontal was smart and it has really paid off.
User avatar
Adblock Plus Fan
 
Posts: 1255
Joined: Sat Feb 24, 2007 12:08 pm

Postby Wladimir Palant » Wed Jan 07, 2009 3:22 pm

"Originating domain" will trigger questions like "Why does it say 'originating domain foo.com' for 'http://bar.com/script.js', isn't it bar.com?"
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Dr. Evil » Wed Jan 07, 2009 4:56 pm

I don't know if this information is available, but maybe the items could be listed hierarchically?
Code: Select all
    http://example.com/image.png               image
  - http://example.com/frame/frame.htm         frame
       http://example.com/frame/image.png      image
       http://example.com/frame/script.js      script
    http://example.com/script.js               script


This would also help finding the right things to block on pages with many items.
Dr. Evil
 
Posts: 194
Joined: Fri Sep 08, 2006 3:51 pm

Postby Wladimir Palant » Wed Jan 07, 2009 5:01 pm

No, that information isn't really available but maybe it can be retrieved. What's more important, the frame URL displayed in the list might have redirected itself to another URL - so the document URL that is being considered for $domain and $third-party doesn't show up in the list at all.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Adblock Plus Fan » Sun Feb 22, 2009 4:06 am

@Wladimir
Is there a chance we can have $domain revised so it considers domain of toppage for items inside frames?
It seems like it's causing confusion and people really expect different behaviour:
http://adblockplus.org/forum/viewtopic.php?t=3538
http://adblockplus.org/forum/viewtopic.php?t=3521

If we can have $domain revised then there's also no need for the requested feature in this thread.
User avatar
Adblock Plus Fan
 
Posts: 1255
Joined: Sat Feb 24, 2007 12:08 pm

Postby Wladimir Palant » Mon Feb 23, 2009 11:10 am

That's how domains always worked for element hiding, I'm not convinced it needs changing.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Wladimir Palant » Thu May 07, 2009 4:02 pm

Done, there is a "document source" column now which is hidden by default: http://hg.mozdev.org/adblockplus/rev/7023575bdf23
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany


Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 3 guests

cron