Bug?

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey
Post Reply
IsraelList
Posts: 73
Joined: Tue Jan 19, 2010 3:28 pm
Contact:

Bug?

Post by IsraelList »

Element Hiding Rules beginning with ! don't function as comments.
Michael
Posts: 1361
Joined: Sat Dec 19, 2009 12:29 pm

Re: Bug?

Post by Michael »

I can confirm that the issue occurs in the latest development build. However, the filters behind comments are not active (because they start with an exclamation mark, which invalidates any domain specification), merely in the blue used for element hiding as opposed to the grey used for comments.
Wladimir Palant

Re: Bug?

Post by Wladimir Palant »

Fixed: https://hg.adblockplus.org/adblockplus/rev/f645babf08f1

It is not a regression, this issue existed virtually forever.

PS: And unit tests: https://hg.adblockplus.org/adblockplus/rev/c1012dc9cf4b
IsraelList
Posts: 73
Joined: Tue Jan 19, 2010 3:28 pm
Contact:

Re: Bug?

Post by IsraelList »

To be fixed on ABP 1.2.1?
Alan
Posts: 289
Joined: Sat Feb 10, 2007 8:47 pm
Location: Colorado, USA

Re: Bug?

Post by Alan »

Apparently so. It's already fixed in the development build.
devbuilds/adblockplus/adblockplus-1.2.0 ... elog.xhtml
Wladimir Palant

Re: Bug?

Post by Wladimir Palant »

To be fixed in Adblock Plus 1.3. If there will be a release from the stable branch (Adblock Plus 1.2.1) taking this patch can be considered. However, given that this isn't a recent regression I would rather not.
Post Reply