If it wasn't a valid filter, it might have moved somewhere else in the list, which would make it harder to find
The selection moves as well however, you never need to find the filter you just edited.
How about using this interface, and using the inline tag editor when a user selects a filter on the list to edit, but having a 'Filters->add filter' menu option that opens a new dialog box?
Sorry, that's a horrible idea. Opening new dialogs should always be prevented whenever possible.
Btw, adding an icon inside a dropdown list is harder than I thought. Does anybody know extensions that do it? Address bar in Firefox doesn't count, it isn't a real dropdown list.
Wladimir Palant wrote:Btw, adding an icon inside a dropdown list is harder than I thought. Does anybody know extensions that do it? Address bar in Firefox doesn't count, it isn't a real dropdown list.
I don't see them in any of MY extension's dropdown boxes. Plenty of dropdowns ... no icons.
It's still pretty easy to create new rules for already blocked items, very good.
Only thing i now do not like is, i can't scroll anymore when i make new filters.
Also switching windows add's it, and i have to double click it again when i edit it more.
I did do some scrolling and switching windows when i added new Element hiding rules.
1st Dev. build with it, but it seems to me that i did get more clicks when i add new Element hiding rules.
If this stays and i think it will:)
Is it good or bad idea, if we move Add filter, Ok, Cancel and Help before filters box.
Wladimir Palant wrote:a new development build is there
Very nice.
Just one thing: Would it be possible to make the editor activate on single click when a line is already selected?
The "Add filter..." line and the button to activate it are pretty far apart from each other - I think this could confuse new ABP users (experienced ones use "return" anyway ).
And as "Add filter..." is already preselected when the preferences panel is opened, I think it would be nice to activate editing with a single click - I can easily imagine users misinterpreting the "Add filter..." as a button, and wondering why clicking it doesn't do anything.
Wladimir Palant wrote:Btw, adding an icon inside a dropdown list is harder than I thought. Does anybody know extensions that do it? Address bar in Firefox doesn't count, it isn't a real dropdown list.
Tb search box has a type of dropdown, with an inline X to do clear which appears only upon text input, which I'm sure you can modify to exit.. This is a very good ergonomic for this type of input box.
I have to say though, I wish we could solve the Apply problem, even if inelegantly. It's incredibly annoying. To the point where the platform independence goal is overridden - I just want to apply the changed filter without closing the Prefs dialog.
alta88 wrote:I have to say though, I wish we could solve the Apply problem, even if inelegantly. It's incredibly annoying. To the point where the platform independence goal is overridden - I just want to apply the changed filter without closing the Prefs dialog.
I wanna be able to Cancel added filters, that is important.