[Done] Warn if the filters didn't download correctly

Various discussions related to Adblock Plus development

[Done] Warn if the filters didn't download correctly

Postby famlam » Mon Nov 07, 2011 12:37 am

Refiled because of this comment:
The last issue will take longer to fix and I have a bug report with a meaningless title now.


Reports like this one do not serve the filter list maintainer: filter download failed. It might be an idea to just notify the user that it failed, so (s)he will check his/her firewall rather that having a non-working ABP. This also saves the list maintainer some time (as it probably isn't the first thing a list maintainer looks at, so (s)he might first try to figure out what could have raised the ad for the user, before (s)he finally notices the download failure)
Also mentioned here before.
famlam
 
Posts: 59
Joined: Sat Aug 07, 2010 2:06 pm

Re: [Roadmap] Warn if the filters didn't download correctly

Postby Wladimir Palant » Mon Dec 05, 2011 9:16 am

Moved to Future development, this is now on the roadmap for Adblock Plus 2.1.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Roadmap] Warn if the filters didn't download correctly

Postby Ares2 » Sat Dec 17, 2011 1:44 pm

Wladimir, is it possible to handle the network errors in detail (e.g. whether it failed at name lookup, SSL handshake, during download etc.)? I also always wonder when I see a "Last download attempt: 30 minutes ago; Last successful download: unknown", whether this was the first attempt after install and it just happened to fail for whatever temporary reason OR whether ABP has already tried several times (e.g. persistent error).
Ares2
 
Posts: 1275
Joined: Fri Feb 15, 2008 1:47 pm

Re: [Roadmap] Warn if the filters didn't download correctly

Postby Wladimir Palant » Tue Dec 20, 2011 1:41 pm

The exact error reason would be a code like 2152398861 (that's NS_ERROR_CONNECTION_REFUSED). Adblock Plus doesn't save it and even if it did - interpreting it isn't trivial (I currently recognize 40 such codes in a log analysis script).

What is being saved is the download status like "synchronize_connection_error" or "synchronize_checksum_mismatch". Sending it to the server shouldn't be a problem. Edit: Stupid me - that's already being sent and even displayed in the reports, "Status of last download" column. I added it as a possible "known issue" field (https://hg.adblockplus.org/sitescripts/rev/a04445af4763), maybe we will implement the request here as a "known issue" for now. That would only need a webpage with description of the issue and how to fix it.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Roadmap] Warn if the filters didn't download correctly

Postby Wladimir Palant » Tue May 08, 2012 3:24 pm

Sending reports if there were no successful downloads in the past 14 days no longer works: https://hg.adblockplus.org/adblockplus/rev/d74cb837db13
This should do as solution here.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany


Return to Adblock Plus development

Who is online

Users browsing this forum: No registered users and 4 guests