[Invalid] Bug causes tab crash

Posting here is no longer possible, please use the corresponding product forum.

[Invalid] Bug causes tab crash

Postby User8888 » Tue Feb 07, 2012 3:47 pm

Hi!
i've just found a weird behaviour of AdBlock. It may cause a tab, opened by click on anchor with target="_blank", to crash when user clicks another anchor with blocked destination. See below.

How to reproduce:
======================
1. Create file t.html with content:
Code: Select all
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title></title>
<META name="description" content="" />
<META name="keywords" content="" />
<META name="robots" content="noindex, nofollow" />
</head>
<body>
<a target='_blank' href='t2.html'>click</a>
</body>
</html>

2. create file t2.html with content:
Code: Select all
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html>
<head>
   <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
   <title>William Hill Poker</title>
   <META name="robots" content="noindex, nofollow" />
</head>
<body>
<a rel='nofollow' href='http://serve.williamhill.com/promoRedirect?campaign=DEFAULT&channel=DEFAULT&zone=111'>William Hill Poker</a>
</body>
</html>

3. Ensure you have set blocking rule on pattert
Code: Select all
/promoredirect?*&campaign=*&zone=

4. load t.html into firefox, click on "click" link to open t2.html
5. click on "William Hill Poker" link to crash current tab. It will silently closed and it is definitely not the behaviour user wanted to see.
==============

Also the crash will occur if t2.html will have document.location.href="http://serve.williamhill.com/promoRedirect?campaign=DEFAULT&channel=DEFAULT&zone=111" statement or if t2.html document will send header('Location: http://serve.williamhill.com/promoRedir ... &zone=111');

Firefox version 10.0
AdBlock Plus 2.0.3, subscription "RuAdList+EasyList (русский, українська)"
Windows 7 x64

From my point of view, the bug is urgent and has very high priority.
Feel free to ask any assistance.

Sincerely yours,
AdBlock supporter.
User8888
 

Re: Bug causes tab crash

Postby User8888 » Tue Feb 07, 2012 3:56 pm

Oh, and BTW: looks like the bug appears with pattern, that parses query/search part of URL.
For example, pattern
Code: Select all
||titanpoker.com^$third-party
doesn't cause the bug, though it does block resource fetching from the blocked domain.
User8888
 

Re: Bug causes tab crash

Postby User8888 » Sat Feb 11, 2012 12:45 pm

Hello? Anybody home? ;)
User8888
 

Re: Bug causes tab crash

Postby vinny86 » Sat Feb 11, 2012 5:59 pm

Who's there ? Go away, am sleepy

Seriously though, Wladimir might be a bit busy, give it a couple of days more :)
User avatar
vinny86
 
Posts: 735
Joined: Thu Sep 16, 2010 6:17 pm

Re: Bug causes tab crash

Postby Wladimir Palant » Mon Feb 13, 2012 11:26 pm

By "tab crash" you probably mean "the tab gets closed"? Sounds like pop-up blocking feature doing its job... See https://adblockplus.org/development-bui ... ng-support.
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Bug causes tab crash

Postby Wladimir Palant » Mon Feb 13, 2012 11:29 pm

Confirmed, this filter in EasyList is responsible:

Code: Select all
||williamhill.com^$image,~image,popup,third-party


It is specifically blocking pop-ups from williamhill.com. If you feel that this shouldn't be done - http://forums.lanik.us/viewforum.php?f=64 is the right place to report such issues. This isn't an Adblock Plus bug however (marking as Invalid).
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Invalid] Bug causes tab crash

Postby User8888 » Tue Feb 14, 2012 7:41 am

Wladimir Palant wrote:Confirmed, this filter in EasyList is responsible:

Code: Select all
||williamhill.com^$image,~image,popup,third-party


It is specifically blocking pop-ups from williamhill.com. If you feel that this shouldn't be done - http://forums.lanik.us/viewforum.php?f=64 is the right place to report such issues. This isn't an Adblock Plus bug however (marking as Invalid).


Hmm...
Don't you think, there is something wrong with that pop-up blocking solution? It doesn't block any real pop-ups, it blocks user from visiting the site!
It is ok to block pop-ups on some sites, but it is definitely not OK to block user from visiting a site, that may cause pop-ups. Don't you think? It looks like a silent censorship and ABP is a tool for it. Don't you think it is wrong?
User8888
 

Re: [Invalid] Bug causes tab crash

Postby Hubird » Tue Feb 14, 2012 8:19 am

Wladimir Palant wrote:If you feel that this shouldn't be done - http://forums.lanik.us/viewforum.php?f=64 is the right place to report such issues. This isn't an Adblock Plus bug however (marking as Invalid).
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: [Invalid] Bug causes tab crash

Postby Wladimir Palant » Tue Feb 14, 2012 10:06 am

The way you opened this tab - it's a pop-up.
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Invalid] Bug causes tab crash

Postby User8888 » Tue Feb 14, 2012 12:31 pm

Dear Wladimir.
What do you mean by "pop-up" ?

In the case, I described at the start of the thread, it is normal behaviour and it is definitely what a user wants to get. User, by himself, clicks a link to open new tab and after that he (again by himself) clicks another link in a new tab to go to destination site. He/She expects to see new site, but instead the tab gets closed! How could this be a normal behaviour?

It is very common and convenient to users to open external links in a new tab/window on some sites. Current handling of such cases in ABP completely destroys it and breaks a lot of good sites like pokerlistings.com Try to click on "William Hill Poker" link there!

I absolutely agree, that there must be a pop-up blocking feature, but please, look attentively at the use-case again, look at pokerlistings.com. It is not about nag pop-ups at all, it destroys normal behaviour!
User8888
 

Re: [Invalid] Bug causes tab crash

Postby Wladimir Palant » Tue Feb 14, 2012 12:50 pm

A pop-up is, on a technical level, something that has a window.opener property (meaning: it was opened by a different window/tab). This applies both to new windows/tabs that the user intended as well as the ones that the user didn't intend to open - we cannot recognize intention (and neither can Firefox which is why some websites manage to get around the built-in pop-up blocker). A pop-up will not necessarily go to its final destination immediately, there might be intermediate steps. Again, we cannot recognize whether the user clicked a link intentionally, because he wanted to go to this location, or whether he was tricked into clicking it, or whether the website navigated to that location automatically.

Now we are of course aware of these uncertainties when blocking pop-ups. This is why my recommendation to filter list authors was: use this feature sparingly, for the definitive cases only, where a pop-up window gets around built-in pop-up blocker and annoys users. I don't know whether williamhill.com meets this criteria - this is something that the filter list authors will be able to tell you. But it would help if you had a real-life issue to present rather than a theoretical construct.
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Invalid] Bug causes tab crash

Postby User8888 » Tue Feb 14, 2012 1:52 pm

"theoretical construct" ?
Are you kidding?
I've just given a completely real life example - go to pokerlistings.com (you can get there from google's SERP easily). Do you see poker-rooms list, that is titled "Best Poker Sites - Editors' Picks" ? Find second row in it. It has "William Hill Poker" link - click on it and observe how new tab gets opened and then immediately - closed.

What is more real-life issue, than this?

There are hundred thousands of good sites, that opens external sites in a new window. They are all affected by this bug if destination domain is listed in filter!
User8888
 

Re: [Invalid] Bug causes tab crash

Postby MonztA » Tue Feb 14, 2012 5:55 pm

||williamhill.com^$image,~image,popup,third-party is indeed a bit too harsh. I want to make it more specific but I am unable to find a site that uses an ad popup from williamhill.com. Anyone knows a site by chance?
MonztA
ABP IT Officer
 
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Re: [Invalid] Bug causes tab crash

Postby User8888 » Tue Feb 14, 2012 9:37 pm

MonztA wrote:||williamhill.com^$image,~image,popup,third-party is indeed a bit too harsh. I want to make it more specific but I am unable to find a site that uses an ad popup from williamhill.com. Anyone knows a site by chance?

Never seen it.

Here one more poker sites, that can't be opened in well-intentioned target='_blank' window: partypoker.com.

BTW, guys, please, take a look at the problem broader. It's not the filter rules issue, it is the issue with the method. It's not OK to close tab when user WANTs to go to the site, that someone compromised to the filter list owner! It's a methodical flaw, that should be solved. Eventually, it is a browser developers work to make correct pop-up blockers, not yours!
User8888
 

Re: [Invalid] Bug causes tab crash

Postby MonztA » Wed Feb 15, 2012 5:31 pm

Removed the rules for now https://hg.adblockplus.org/easylist/rev/03cd46888307

I will add more specific filters when I come across ad popups.
MonztA
ABP IT Officer
 
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany


Return to Bug reports

Who is online

Users browsing this forum: No registered users and 3 guests