Hi,
Not a very big bug as I doubt anyone will use trailing-dot-domain URLs, but worth mentioning:
If you visit http://torrentz.eu./ (or any random http URL and just append a dot to the domain) the following bugs can be found:
1. the EHH suggests the domain ""
2. the generated domain-specific filter from the EHH (foo.bar.##anything) won't apply to the page, (neither will foo.bar##anything).
Kind regards,
Famlam
[Fixed] Domain with a trailing dot: hiding rules won't apply
Re: Domains with a trailing dot: hiding rules won't apply
The correct rule would be indeed "foo.bar.##anything" - Gecko treats "foo.bar." and "foo.bar" as different domains.
Now there are apparently two issues in how we are handling this domain name, will look into it.
Now there are apparently two issues in how we are handling this domain name, will look into it.
Re: [Fixed] Domain with a trailing dot: hiding rules won't apply
Thanks!
FYI, from your patch (line 1.87):
Shouldn't that be
as you are uppercasing twice?
FYI, from your patch (line 1.87):
Code: Select all
if (this.ignoreTrailingDot)
docDomain = docDomain.replace(/\.+$/, "").toUpperCase();
docDomain = docDomain.toUpperCase();
Code: Select all
if (this.ignoreTrailingDot)
docDomain = docDomain.replace(/\.+$/, "");
docDomain = docDomain.toUpperCase();
Re: [Fixed] Domain with a trailing dot: hiding rules won't apply
You are correct, thanks for noticing!
Fixed: https://hg.adblockplus.org/adblockplus/rev/db19b081bd9c
Fixed: https://hg.adblockplus.org/adblockplus/rev/db19b081bd9c