[Fixed] ABP blocks ads when domain is whitelisted.

Posting here is no longer possible, please use the corresponding product forum.
Locked
nobodyfamous

[Fixed] ABP blocks ads when domain is whitelisted.

Post by nobodyfamous »

On any site with Google Adsense, ABP is blocking the ads even when the site is whitelisted. Sometimes they appear for a second then disappear. Also, the blank space where the ad is remains, unlike if ABP is turned on for that site it removes the space.

I'm guessing it's because the ads load in an iframe? So ABP is blocking googlesyndication.com or whatever, and still blocking it when the parent site is something else.
User avatar
Crits
Posts: 394
Joined: Mon Jan 16, 2012 11:54 am
Location: France
Contact:

Re: ABP blocks ads when domain is whitelisted.

Post by Crits »

I can reproduce your problem on Google Chrome with ABP 1.3
Test page: http://www.malekal.com/ (left column of the page)

(Note that this problem normally doesn't occur with Firefox)

As I have always been using Firefox, I don't know if this is a regression brought by ABP 1.3 or if the problem already existed before the 1.3 version.
I guess this will be fixed soon by the dev.
Last edited by Crits on Mon Oct 29, 2012 7:40 pm, edited 1 time in total.
Author of Liste FR, an ad-blocking subscription for French websites
rollex

Re: ABP blocks ads when domain is whitelisted.

Post by rollex »

This bug is only since the last update. Before it was working fine.
I had open few days ago a post about it : forum/viewtopic.php?f=11&t=11339
oleiros

Re: ABP blocks ads when domain is whitelisted.

Post by oleiros »

Same here. After update, the adsense from my news site (http://www.efe.com) is blocked even with the domain included in whitelist. No issues with FF.
Wladimir Palant

Re: ABP blocks ads when domain is whitelisted.

Post by Wladimir Palant »

I think it's a caching issue. A fix is already under review: http://codereview.adblockplus.org/8691076/
Wladimir Palant

Re: ABP blocks ads when domain is whitelisted.

Post by Wladimir Palant »

The caching issue will be fixed in the next development build (will be out in 15 minutes). It would be nice if somebody could install the development build and verify that the issue here is fixed as well.
User avatar
Crits
Posts: 394
Joined: Mon Jan 16, 2012 11:54 am
Location: France
Contact:

Re: ABP blocks ads when domain is whitelisted.

Post by Crits »

Reporting as fixed on Chrome 22.0.1229.96 m, with the latest development build!

Test pages:
http://www.malekal.com/
http://www.hellokitty.fr/
Author of Liste FR, an ad-blocking subscription for French websites
rollex

Re: [Fixed] ABP blocks ads when domain is whitelisted.

Post by rollex »

I confirm it's ok on Chrome 22.0.1229.94 m with the latest development build.
Test page : http://vr-annexe.akroweb.fr/
User avatar
krunk
Posts: 2
Joined: Sun Oct 28, 2012 10:53 am
Contact:

Re: [Fixed] ABP blocks ads when domain is whitelisted.

Post by krunk »

Glad to see this has been fixed! Great job guys!
xkz

Re: [Fixed] ABP blocks ads when domain is whitelisted.

Post by xkz »

First, sorry for my bad english xD

I am webmaster of a small web site and we support the not-intruder advertising (non-massive adversiting). We have only one advertisement in a wings to survive. Some of our users want to support us, and because of it they deactivate adblockplus in our web. Nevertheless, for a little time, our visitors have informed us that they cannot visualize the advertisement when they add the web to the white list.

I've checked it from Chrome Updated and ABP 1.3

Thank you,

Regards
MonztA
ABP Developer
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Re: [Fixed] ABP blocks ads when domain is whitelisted.

Post by MonztA »

It was fixed in Adblock Plus for Chrome 1.3.1 which was released some hours ago. Can you test it with the new version?
Guest

Re: [Fixed] ABP blocks ads when domain is whitelisted.

Post by Guest »

MonztA wrote:It was fixed in Adblock Plus for Chrome 1.3.1 which was released some hours ago. Can you test it with the new version?
Right! Is working now!

But I can't update from Chrome :S I have had to uninstall ABP and download again. Is possible to update it automatically?

Thanks!
MonztA
ABP Developer
Posts: 3957
Joined: Mon Aug 14, 2006 12:18 am
Location: Germany

Re: [Fixed] ABP blocks ads when domain is whitelisted.

Post by MonztA »

Sure, all users on 1.3 will get the 1.3.1 update in the next hours (or so). You can tick "Developer Mode" in the extension tab in Chrome. It will show a button that allows searching for updates of your extension(s).
xkz

Re: [Fixed] ABP blocks ads when domain is whitelisted.

Post by xkz »

MonztA wrote:Sure, all users on 1.3 will get the 1.3.1 update in the next hours (or so). You can tick "Developer Mode" in the extension tab in Chrome. It will show a button that allows searching for updates of your extension(s).
Thank you so much and sorry for my ignorance ;)
Locked