[Done] Removing "Block in local pages"

Various discussions related to Adblock Plus development

[Done] Removing "Block in local pages"

Postby Wladimir Palant » Fri Jan 05, 2007 4:33 pm

I have just extended the definition of "local pages" to data: and javascript: URLs to make sure images in those can be blocked as well (greetings to Yahoo). Given this, does the option "Block remote ads in local pages" still make sense? It seems that it should be always switched on, I don't see any reasons why one would switch it off. The original idea was that local pages should be treated as special since you open them from your disk and they are under your control. However, this special treatment seems to be unjustified.

I would remove both the visible option in the user interface and the preference in about:config. Then I could kill the "Not a remote page" message in the sidebar since it is basically the same old "No blockable items" now. Any reason why I shouldn't do this?
Last edited by Wladimir Palant on Thu Oct 30, 2008 12:18 pm, edited 1 time in total.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby gogoban » Fri Jan 05, 2007 5:23 pm

I do not see a problem. I have it on all the time without issues. And if someone has problems, he can whitelist a local page.

What is the (technical) definition of a local page? file://? Or special IP (127.0.0.1)? Or is it something Firefox defines itself?
gogoban
 

Postby Wladimir Palant » Fri Jan 05, 2007 5:40 pm

Technically it is everything you have in extensions.adblockplus.localschemes which is mostly file:// and a few mail schemes. Starting with Adblock Plus 0.7.2.4 it will be data: and javascript: as well - while you shouldn't be able to block data: and javascript: URLs, blocking remote images in them should be possible.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby ziutek » Fri Jan 05, 2007 11:15 pm

Go ahead. This option never made much sense - the fact that a file is local does not in any way imply that it should be trusted more.
ziutek
 

Postby sheepy » Sat Jan 06, 2007 11:11 am

I'd say no special treatment. I occasionally grab reference sites since it's faster to browse them offline. And sometimes I may want to block their banner / logo to maximise content area.
sheepy
 
Posts: 147
Joined: Sat Jun 17, 2006 8:44 pm

Postby rick752 » Sat Jan 06, 2007 5:56 pm

The ads should just be blocked either way (local or online). You could always just disable ABP if you had a need otherwise.
User avatar
rick752
 
Posts: 2709
Joined: Fri Jun 09, 2006 7:59 pm
Location: New York USA

Postby Peng » Mon Jan 08, 2007 3:20 pm

I agree with removing it. Whoever doesn't want to block ads in local pages for some reason can whitelist them.
Matt Nordhoff
User avatar
Peng
 
Posts: 518
Joined: Fri Jun 09, 2006 8:14 pm
Location: Central Florida

Postby IceDogg » Mon Jan 08, 2007 7:41 pm

I too agree. Remove it, whitelist if you need to see the ads on pages your have stored or such. JMO
IceDogg
 
Posts: 909
Joined: Fri Jun 09, 2006 11:22 pm

Postby Stupid Head » Mon Jan 08, 2007 8:04 pm

Another vote for removing it. I'm all for simplifying.
What, me worry?
User avatar
Stupid Head
 
Posts: 214
Joined: Sat Aug 26, 2006 8:11 pm
Location: USA

Postby ecjs » Mon Jan 08, 2007 8:14 pm

Yep.
ecjs
 
Posts: 170
Joined: Sun Jun 11, 2006 7:39 pm

Postby Wladimir Palant » Mon Jan 08, 2007 8:24 pm

It seems we are unanimous on this. I will remove this option them.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Wladimir Palant » Tue Jan 30, 2007 2:26 pm

Done, this option has been removed in the current development build.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany


Return to Adblock Plus development

Who is online

Users browsing this forum: Google [Bot] and 7 guests