[Invalid] ABP 2.1b + url-addon-bar = no ABP button

Posting here is no longer possible, please use the corresponding product forum.

[Invalid] ABP 2.1b + url-addon-bar = no ABP button

Postby df » Wed Jun 20, 2012 5:11 pm

If "url-addon-bar" add-on is enabled, no ABP-button appears. It happens since ABP is restartless

Is it a ABP or url-addon-bar bug?
df
 

Re: ABP 2.1b + url-addon-bar = no ABP button

Postby Wladimir Palant » Wed Jun 20, 2012 9:28 pm

I don't see this issue - everything seems to work fine even if url-addon-bar is installed. What happens if you go into Adblock Plus options and check "Show in add-on bar"?
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: ABP 2.1b + url-addon-bar = no ABP button

Postby df » Wed Jun 20, 2012 9:45 pm

After installing it works, but after restarting Firefox not. After restart i can't activate "Show in add-on bar".
df
 

Re: ABP 2.1b + url-addon-bar = no ABP button

Postby Wladimir Palant » Wed Jun 20, 2012 11:06 pm

Nope, I explicitly tested restart as well - still works for me after a restart (Firefox 13 and Firefox 16.0a1).
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: ABP 2.1b + url-addon-bar = no ABP button

Postby Rayge » Wed Jun 20, 2012 11:08 pm

My Adblock Plus Button also disappeared since int's restartless. I always had it next to the URL Bar. The Button also does not appear under "customize" anymore so I can't put it back.
Rayge
 

Re: ABP 2.1b + url-addon-bar = no ABP button

Postby Wladimir Palant » Wed Jun 20, 2012 11:09 pm

@Rayge: Open Add-ons Manager, select Adblock Plus, click Options button and then check "Show in add-on bar" - does that work? If not: please create a new topic, mixing up unrelated issues in one topic makes things harder for me to investigate and fix.
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: ABP 2.1b + url-addon-bar = no ABP button

Postby Rayge » Wed Jun 20, 2012 11:11 pm

Yes, I can get it to show up in Addon Bar, but not at the top next to the URL Bar, since it does not appear under "customize" anymore. I use the latest Aurora. and the latest Adblock Plus Developer Version.
Rayge
 

Re: ABP 2.1b + url-addon-bar = no ABP button

Postby Wladimir Palant » Wed Jun 20, 2012 11:12 pm

Rayge, just drag it to the other toolbar while the Customize window is open...
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: ABP 2.1b + url-addon-bar = no ABP button

Postby Rayge » Wed Jun 20, 2012 11:19 pm

Thank you, that worked =)
Rayge
 

Re: ABP 2.1b + url-addon-bar = no ABP button

Postby df » Thu Jun 21, 2012 12:07 am

i figured it out, it's a combination of url-addon-bar and Toolbar Appmenu Button. If both add-on are enabled, the button doesn't appears.
df
 

Re: ABP 2.1b + url-addon-bar = no ABP button

Postby Wladimir Palant » Thu Jun 21, 2012 3:45 pm

That makes more sense. I'm not sure how but Toolbar Appmenu Button (particularly its "Shring Titlebar" feature) breaks the relationship between the toolbar and its toolbox - toolbar.toolbox property is simply null. Consequently, Adblock Plus ignores it as an invalid toolbar (adding buttons to it isn't possible). I would recommend notifying Toolbar Appmenu Button author about this issue. Also, I would recommend staying away from the "Shring Titlebar" feature - it uses mutation events meaning that it slows down the browser considerably.

Marking as Invalid since that's clearly not our bug.
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Invalid] ABP 2.1b + url-addon-bar = no ABP button

Postby df » Thu Jun 21, 2012 3:57 pm

Without this feature ABP button appears.
Image
df
 

Re: [Invalid] ABP 2.1b + url-addon-bar = no ABP button

Postby Wladimir Palant » Mon Jul 09, 2012 4:27 pm

Turned out that I was wrong and the bug is actually in url-addon-bar. I notified the author that he shouldn't be removing the toolboxid attribute from the add-on bar, this is actually what's causing the issues.
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: [Invalid] ABP 2.1b + url-addon-bar = no ABP button

Postby guest » Sat Feb 23, 2013 10:01 am

test
guest
 

Re: [Invalid] ABP 2.1b + url-addon-bar = no ABP button

Postby guest » Sat Feb 23, 2013 10:09 am

Sorry for the test message above.

I just wanted to add my very similar experience w/ FireFox 19. I lost the icon completely, not even available anywhere even when in Customize mode. The option to check "show in addonbar" could not be selected. My solution was to Disable every addon except AdBlock Plus, restart Firefox, then finally I could check the "show in addonbar", and it would appear where
it always has been.

Unbelievably while typing this comment - the AdBlock Plus icon just disappeared - even after it had been working for over
an hour. I guess I will do the above steps again to get it back. It seems something is "overwriting" its ID if i had to guess.

<sigh>
guest
 

Next

Return to Bug reports

Who is online

Users browsing this forum: No registered users and 1 guest