frames not blocked if the host is whitelisted

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey

frames not blocked if the host is whitelisted

Postby Samus_ » Mon Jun 08, 2009 11:02 am

hello, it seems that when a site is whitelisted and that site has a frame with content from a different domain, that domain gets indirectly whitelisted as well.

example: if you whitelist reddit.com the following link will show ads: http://www.reddit.com/tb/8qgct while a direct link: http://www.wired.co.uk/news/archive/200 ... water.aspx will block them.

is this intentional?

I'm using easylist on ArchLinux, browser: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.10) Gecko/2009042810 GranParadiso/3.0.10
Samus_
 
Posts: 6
Joined: Mon Jun 08, 2009 10:24 am

Postby Wladimir Palant » Mon Jun 08, 2009 1:48 pm

Yes, that's intentional - site whitelisting goes by the address of the top frame. So if the ABP icon turns green everything you see in the browser window is whitelisted, regardless of where the content actually comes from. Reason: that way it is more obvious for users who might not be accustomed with the deeper matters of HTML.
Wladimir Palant
ABP Developer
 
Posts: 8397
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Postby Samus_ » Tue Jun 09, 2009 11:41 am

hmm yes, makes sense however it would be nice if there were an "advanced" option allowing us to override that, because now we have to choose between supporting the site or unblocking the whole net :P and there's quite a lot of highly popular sites using toolbars (reddit, digg, retweet, etc.).

anyways in my particular case I just managed to create a set of filters that allow me to see the ads on the main site and subreddits and block them for the toolbar (i.e. external content) here:

Code: Select all
@@|http://*.reddit.com/|
@@|http://*.reddit.com/r/
|http://*.reddit.com/tb/


this because recently the toolbar was moved to its own url, two weeks ago this couldn't be done.

thanks guys!
Samus_
 
Posts: 6
Joined: Mon Jun 08, 2009 10:24 am

Postby Fox » Tue Jun 09, 2009 12:10 pm

You can use this whitelisting rule:
@@|http://www.reddit.com/$~document

~document filter option means that whole page is not whitelisted,
only those items that starts with http://www.reddit.com/ are whitelisted.

But i think you need to open your Blockable items (Ctrl+Shift+V) list at reddit.com
and turn off those Element hiding rules.
(Because it seems that, that rule does not whitelist those.)

And also add these rules to Adblock Plus:
@@|http://ad.doubleclick.net/*$domain=reddit.com
@@|http://m1.2mdn.net/*$domain=reddit.com
Fox
 
Posts: 300
Joined: Sat Jun 10, 2006 3:05 pm
Location: Finland


Return to Adblock Plus for Firefox support

Who is online

Users browsing this forum: ShanaBrum and 12 guests