Don't count filter hits while browsing in private mode

[Fury]

Hi,

I think the private mode in firefox shouldn't leave any data on the computer. I just cleared my Adblock Plus statistic (filter hits), switched to the "porn-mode" and surfed for a while. After I ended the private mode the Adblock Plus statistic wasn't empty.

I think Adblock Plus shouldn't count the filter matched while the private mode is on. Otherwise it is possible to identify some of the sites a person visited browsing in private mode.

[Ares2]

Hits shouldn't be counted in private browsing mode

Added support for private browsing mode in Firefox 3.1, hit statistics are disabled automatically

[Fury]

Hi Ares,

I created a new firefox profile and installed only APB. I forgot to disable the ubuntu-firefox-modifications. I got the same result with this profile. The hit where counted as I was browsing in the private mode.

http://blip.tv/dashboard/episode/3056364

The hits are counted even with the ubuntu-firefox-modifications disabled. (I didn't film this second try).

[Ares2]

You are right, I just tried it myself and hit counts are still going up after starting the private browsing mode (Sorry that i didn't check it before ).

[Wladimir Palant]

Confirmed, something is broken

[Wladimir Palant]

Fixed: https://hg.adblockplus.org/adblockplus/rev/89ba01b2334f
This should be working correctly again in the next development build. Looks like I was too careless when cleaning up before Adblock Plus 1.1.2 release.

[Wladimir Palant]

I created an Adblock Plus 1.1.x branch - plan is to release Adblock Plus 1.1.3 from the branch, only difference to Adblock Plus 1.1.2 will be the fix above. Please install 2010010502 development build from devbuilds/adblockplus/ once it is out (usually 01:20 AM GMT) and confirm that private browsing integration works again (hits aren't being counted in private browsing mode). I should then release Adblock Plus 1.1.3 around Wednesday.

[Fury]

I won't have time to install before work tomorrow (Germany) and I'm busy tomorrow evening. I probably won't be able to test the dev build before wednesday or late tuesday evening.