Bug?

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey

Bug?

Postby IsraelList » Fri Apr 30, 2010 12:26 am

Element Hiding Rules beginning with ! don't function as comments.
IsraelList
 
Posts: 73
Joined: Tue Jan 19, 2010 4:28 pm

Re: Bug?

Postby Michael » Fri Apr 30, 2010 7:35 am

I can confirm that the issue occurs in the latest development build. However, the filters behind comments are not active (because they start with an exclamation mark, which invalidates any domain specification), merely in the blue used for element hiding as opposed to the grey used for comments.
Michael
 
Posts: 1361
Joined: Sat Dec 19, 2009 1:29 pm

Re: Bug?

Postby Wladimir Palant » Fri Apr 30, 2010 2:43 pm

Fixed: https://hg.adblockplus.org/adblockplus/rev/f645babf08f1

It is not a regression, this issue existed virtually forever.

PS: And unit tests: https://hg.adblockplus.org/adblockplus/rev/c1012dc9cf4b
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Bug?

Postby IsraelList » Fri May 07, 2010 4:03 am

To be fixed on ABP 1.2.1?
IsraelList
 
Posts: 73
Joined: Tue Jan 19, 2010 4:28 pm

Re: Bug?

Postby Alan » Fri May 07, 2010 5:51 am

Apparently so. It's already fixed in the development build.
https://adblockplus.org/devbuilds/adblo ... elog.xhtml
Alan
 
Posts: 289
Joined: Sat Feb 10, 2007 9:47 pm
Location: Colorado, USA

Re: Bug?

Postby Wladimir Palant » Fri May 07, 2010 8:20 am

To be fixed in Adblock Plus 1.3. If there will be a release from the stable branch (Adblock Plus 1.2.1) taking this patch can be considered. However, given that this isn't a recent regression I would rather not.
Wladimir Palant
ABP Developer
 
Posts: 8395
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany


Return to Adblock Plus for Firefox support

Who is online

Users browsing this forum: BuyEssayOnline and 22 guests