Feature Request: Change "!" to something else

Everything about using Adblock Plus on Mozilla Firefox, Thunderbird and SeaMonkey

Feature Request: Change "!" to something else

Postby K » Sat Oct 09, 2010 12:21 am

The "!" column is cryptic and a bit scary, perhaps ABP could use a "snail" column to mark slow filters, with tiny snail icons to flag them instead. (A turtle would work too.)
K
 

Re: Feature Request: Change "!" to something else

Postby IceDogg » Sat Oct 09, 2010 1:34 am

No expert but ! means attention in lots of things. I can't list them cause I can't remember them off top of my head but I think it's ok. But that's just my opinion.
IceDogg
 
Posts: 909
Joined: Fri Jun 09, 2006 11:22 pm

Re: Feature Request: Change "!" to something else

Postby Hubird » Sat Oct 09, 2010 2:40 am

I like the idea of a snail but I'm not sure if it is piratical, would be quite small.
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: Feature Request: Change "!" to something else

Postby Wladimir Palant » Mon Oct 11, 2010 10:35 am

That ok as a suggestion - but I need an actual snail icon. Here is an example of my graphical skills: :)
Image
Can somebody do better? It has to be an icon that looks reasonably well on different backgrounds. Icon height at most 16 pixels. Please don't suggest any icons from the web, the license there is usually unclear or incompatible.
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Feature Request: Change "!" to something else

Postby Hubird » Mon Oct 11, 2010 12:29 pm

What different backgrounds would it be used on ?

Any other specifics apart from it being at most 16 pixels high ?
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: Feature Request: Change "!" to something else

Postby fanboy » Mon Oct 11, 2010 12:46 pm

I prefer the current option, i need no picture :P
User avatar
fanboy
 
Posts: 3446
Joined: Sun Jun 17, 2007 4:45 am

Re: Feature Request: Change "!" to something else

Postby Wladimir Palant » Mon Oct 11, 2010 2:09 pm

@Hubird: For backgrounds, pick any of those: https://addons.mozilla.org/themes/ ;)

@fanboy: I believe you. However, an image might help less experienced users quite a bit, not everybody is used to reading tooltips. And it won't really be an inconvenience for you.
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Feature Request: Change "!" to something else

Postby Hubird » Mon Oct 11, 2010 2:22 pm

Wladimir Palant wrote:@Hubird: For backgrounds, pick any of those: https://addons.mozilla.org/themes/ ;)


Choosing colours that work with both a light and dark theme does not really seem doable to me.... Shouldn't we just concentrate on it looking good with the default theme (seems more realistic to me) ?
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: Feature Request: Change "!" to something else

Postby Wladimir Palant » Mon Oct 11, 2010 2:57 pm

Second attempt:

Image
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Feature Request: Change "!" to something else

Postby IceDogg » Mon Oct 11, 2010 4:36 pm

Actually Wladimir Palant I think your second one looks great.
IceDogg
 
Posts: 909
Joined: Fri Jun 09, 2006 11:22 pm

Re: Feature Request: Change "!" to something else

Postby Hubird » Mon Oct 11, 2010 6:00 pm

IceDogg wrote:Actually Wladimir Palant I think your second one looks great.


I was going to see about getting an icon drawn but the second attempt looks fine to me also.
User avatar
Hubird
 
Posts: 2850
Joined: Thu Oct 26, 2006 2:59 pm
Location: Australia

Re: Feature Request: Change "!" to something else

Postby Wladimir Palant » Mon Oct 11, 2010 7:24 pm

Ok, done: https://hg.adblockplus.org/adblockplus/rev/23961880afe4

Here is what it looks like in the dialog:
Image
Fortunately, black background is relatively rare - it won't look great there.
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Feature Request: Change "!" to something else

Postby Guest » Sat Nov 06, 2010 3:53 am

Perhaps an hour glass icon might be a better choice as it wouldn't have to be that detailed and thereby would look less overloaded than the current snail icon.
Additionally, I think it could be useful to mark slow filters in the list of blockable items (as well as in its tooltips), too.
Guest
 

Re: Feature Request: Change "!" to something else

Postby Wladimir Palant » Sat Nov 06, 2010 9:55 am

Hourglass: simpler but probably also more ambiguous.

Slow filters in blockable items: little point to that, a filter isn't only slow when it is blocking something. A regular expression that doesn't block anything at all still slows down matching.
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: Feature Request: Change "!" to something else

Postby frank1119 » Sat Nov 13, 2010 1:20 pm

The snail could do, but to be honest: The first time I saw it, I had to search the documentation to find out what it means. Maybe a tooltip on the snail 'slow filter' will clarify everything?
frank1119
 

Next

Return to Adblock Plus for Firefox support

Who is online

Users browsing this forum: No registered users and 8 guests