[Fixed] image context menu cause zombie compartment

Posting here is no longer possible, please use the corresponding product forum.

[Fixed] image context menu cause zombie compartment

Postby dindog » Fri Dec 02, 2011 4:09 pm

just update to new 2.0b3268, and notice when I right click an image, it will hold a zombie compartment in about:memory.

Here is how I reproduce, no filter subscription needed:
1. open about:memory
2. open http://www.google.com
3. right-click on "google" the image, the context menu pop-up
4. close google tab, observe about:memory
5. the http://www.google.com compartment will stay there forever... until
6. you trigger another pop-up:
    a) it's an image context menu, then this tab's compartment will take the zombie role..
    b) right click in blank area, the google zombie will be GC in a few second

So it seem the context menu of image hold a global object prevent GC. I am not sure whether it only the image context menu, but you'll easy fix other, if any, to locate the reason of this issue.
dindog
 
Posts: 14
Joined: Sun Dec 12, 2010 8:07 pm

Re: image context menu cause zombie compartment

Postby Wladimir Palant » Mon Dec 05, 2011 3:51 pm

Please click "Minimize memory usage" in about:memory - does the compartment go away then? If it does then it isn't a zombie compartment.

For reference: I tried to reproduce in a Firefox 11 nightly, without success. I guess you are using Firefox 8?
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: image context menu cause zombie compartment

Postby dindog » Mon Dec 05, 2011 7:01 pm

Nightly and dev version of ABP

I have this consecutive reproduce... just try that in 12-5 nightly and ABP 2.0b.3287. Win7 sp1 32bit

"Minimize memory usage" has no effect.

The key-point is you have to right click on a image, then close the page.
dindog
 
Posts: 14
Joined: Sun Dec 12, 2010 8:07 pm

Re: image context menu cause zombie compartment

Postby Wladimir Palant » Tue Dec 06, 2011 10:58 am

No problem here with pretty much the same configuration. Are you sure that this isn't some other extension interfering? Adblock Plus definitely doesn't hold any references unless you actually click "Block image" (in which case the dialog opening holds a reference to the image and prevents the compartment from being released).
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany

Re: image context menu cause zombie compartment

Postby dindog » Tue Dec 06, 2011 11:22 am

reproduce with fresh new profile, only ADP is installed.

And I also reproduce it in virtual machines, one is WinXP sp3 32bit, the other is Linux Fedora
dindog
 
Posts: 14
Joined: Sun Dec 12, 2010 8:07 pm

Re: image context menu cause zombie compartment

Postby Wladimir Palant » Tue Dec 06, 2011 11:53 am

Don't know why I couldn't reproduce it at first, now I realized what's going on. Fixed: https://hg.adblockplus.org/adblockplus/rev/34b2b91586ff (will be in the next development build, in 25 minutes). Not a new issue however, this always worked like this (at least since 1.0).
Wladimir Palant
ABP Developer
 
Posts: 8398
Joined: Fri Jun 09, 2006 6:59 pm
Location: Cologne, Germany


Return to Bug reports

Who is online

Users browsing this forum: No registered users and 1 guest